Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify parsing of Full Flex event_trigger_data value #1192

Merged
merged 1 commit into from
Mar 15, 2024

Conversation

apasel422
Copy link
Collaborator

@apasel422 apasel422 commented Mar 13, 2024

@apasel422 apasel422 marked this pull request as ready for review March 13, 2024 13:13
@apasel422 apasel422 merged commit d991bb9 into WICG:main Mar 15, 2024
3 checks passed
@apasel422 apasel422 deleted the spec-value branch March 15, 2024 18:42
aarongable pushed a commit to chromium/chromium that referenced this pull request Mar 15, 2024
But do not call it yet during actual parsing, since the value itself is
not yet used by the storage layer.

WICG/attribution-reporting-api#1192

Bug: 40287976
Change-Id: I54fe4ae8f36017cad17fb0274035afcd591e6946
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5367804
Reviewed-by: Nan Lin <[email protected]>
Reviewed-by: Ken Buchanan <[email protected]>
Commit-Queue: Andrew Paseltiner <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1273597}
aarongable pushed a commit to chromium/chromium that referenced this pull request Mar 16, 2024
This reverts commit ff6d441.

Reason for revert: death test failing since check messages are elided
in official builds.
https://ci.chromium.org/ui/p/chrome/builders/ci/linux-chromeos-chrome/40135/overview

Original change's description:
> Add parser for Full Flex event-trigger value field
>
> But do not call it yet during actual parsing, since the value itself is
> not yet used by the storage layer.
>
> WICG/attribution-reporting-api#1192
>
> Bug: 40287976
> Change-Id: I54fe4ae8f36017cad17fb0274035afcd591e6946
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5367804
> Reviewed-by: Nan Lin <[email protected]>
> Reviewed-by: Ken Buchanan <[email protected]>
> Commit-Queue: Andrew Paseltiner <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1273597}

Bug: 40287976
Change-Id: I267ac1225dd602c0405c89c73afb2e7c3d84a5b7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5374851
Commit-Queue: Daniel Cheng <[email protected]>
Auto-Submit: Daniel Cheng <[email protected]>
Owners-Override: Daniel Cheng <[email protected]>
Commit-Queue: Rubber Stamper <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1273780}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants