Explainer and spec update for header errors debug reports #1180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
641d04b
to
aafba0c
Compare
|
@arpanah Could you PTAL, thanks! |
apasel422
previously requested changes
Feb 29, 2024
Co-authored-by: Andrew Paseltiner <[email protected]>
apasel422
approved these changes
Mar 4, 2024
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Mar 4, 2024
WICG/attribution-reporting-api#1180 This CL introduces a new mojo method in AttributionDataHost mojo interface to plumb the errors from header validation in the renderer to the browser. This is necessary as the permission check for debug reporting is performed in the browser, and also it helps to unify the code path for errors from header validation in the browser. Change-Id: If8c0f1295dfc08d914138362c9275b0952b2e4b4
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Mar 4, 2024
WICG/attribution-reporting-api#1180 This CL introduces a new mojo method in AttributionDataHost mojo interface to plumb the errors from header validation in the renderer to the browser. This is necessary as the permission check for debug reporting is performed in the browser, and also it helps to unify the code path for errors from header validation in the browser. Change-Id: If8c0f1295dfc08d914138362c9275b0952b2e4b4
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Mar 4, 2024
WICG/attribution-reporting-api#1180 This CL introduces a new mojo method in AttributionDataHost mojo interface to plumb the errors from header validation in the renderer to the browser. This is necessary as the permission check for debug reporting is performed in the browser, and also it helps to unify the code path for errors from header validation in the browser. Change-Id: If8c0f1295dfc08d914138362c9275b0952b2e4b4
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Mar 4, 2024
WICG/attribution-reporting-api#1180 This CL introduces a new mojo method in AttributionDataHost mojo interface to plumb the errors from header validation in the renderer to the browser. This is necessary as the permission check for debug reporting is performed in the browser, and also it helps to unify the code path for errors from header validation in the browser. Bug: 328043301 Change-Id: If8c0f1295dfc08d914138362c9275b0952b2e4b4
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Mar 4, 2024
WICG/attribution-reporting-api#1180 This CL introduces a new mojo method in AttributionDataHost mojo interface to plumb the errors from header validation in the renderer to the browser. This is necessary as the permission check for debug reporting is performed in the browser, and also it helps to unify the code path for errors from header validation in the browser. Bug: 328043301 Change-Id: If8c0f1295dfc08d914138362c9275b0952b2e4b4
akashnadan
approved these changes
Mar 4, 2024
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Mar 4, 2024
WICG/attribution-reporting-api#1180 This CL introduces a new mojo method in AttributionDataHost mojo interface to plumb the errors from header validation in the renderer to the browser. This is necessary as the permission check for debug reporting is performed in the browser, and also it helps to unify the code path for errors from header validation in the browser. Bug: 328043301 Change-Id: If8c0f1295dfc08d914138362c9275b0952b2e4b4
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Mar 4, 2024
WICG/attribution-reporting-api#1180 This CL introduces a new mojo method in AttributionDataHost mojo interface to plumb the errors from header validation in the renderer to the browser. This is necessary as the permission check for debug reporting is performed in the browser, and also it helps to unify the code path for errors from header validation in the browser. Bug: 328043301 Change-Id: If8c0f1295dfc08d914138362c9275b0952b2e4b4
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Mar 5, 2024
WICG/attribution-reporting-api#1180 This CL introduces a new mojo method in AttributionDataHost mojo interface to plumb the errors from header validation in the renderer to the browser. This is necessary as the permission check for debug reporting is performed in the browser, and also it helps to unify the code path for errors from header validation in the browser. Bug: 328043301 Change-Id: If8c0f1295dfc08d914138362c9275b0952b2e4b4
arpanah
approved these changes
Mar 5, 2024
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Mar 5, 2024
WICG/attribution-reporting-api#1180 This CL introduces a new mojo method in AttributionDataHost mojo interface to plumb the errors from header validation in the renderer to the browser. This is necessary as the permission check for debug reporting is performed in the browser, and also it helps to unify the code path for errors from header validation in the browser. Bug: 328043301 Change-Id: If8c0f1295dfc08d914138362c9275b0952b2e4b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5334963 Reviewed-by: Nate Chapin <[email protected]> Reviewed-by: Brendon Tiszka <[email protected]> Reviewed-by: Andrew Paseltiner <[email protected]> Reviewed-by: Avi Drissman <[email protected]> Commit-Queue: Nan Lin <[email protected]> Cr-Commit-Position: refs/heads/main@{#1268584}
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Mar 5, 2024
WICG/attribution-reporting-api#1180 This CL introduces a new mojo method in AttributionDataHost mojo interface to plumb the errors from header validation in the renderer to the browser. This is necessary as the permission check for debug reporting is performed in the browser, and also it helps to unify the code path for errors from header validation in the browser. Bug: 328043301 Change-Id: If8c0f1295dfc08d914138362c9275b0952b2e4b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5334963 Reviewed-by: Nate Chapin <[email protected]> Reviewed-by: Brendon Tiszka <[email protected]> Reviewed-by: Andrew Paseltiner <[email protected]> Reviewed-by: Avi Drissman <[email protected]> Commit-Queue: Nan Lin <[email protected]> Cr-Commit-Position: refs/heads/main@{#1268584}
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Mar 14, 2024
…ttribution Reporting API, a=testonly Automatic update from web-platform-tests Support header error debug reports for Attribution Reporting API WICG/attribution-reporting-api#1180 This CL introduces a new mojo method in AttributionDataHost mojo interface to plumb the errors from header validation in the renderer to the browser. This is necessary as the permission check for debug reporting is performed in the browser, and also it helps to unify the code path for errors from header validation in the browser. Bug: 328043301 Change-Id: If8c0f1295dfc08d914138362c9275b0952b2e4b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5334963 Reviewed-by: Nate Chapin <[email protected]> Reviewed-by: Brendon Tiszka <[email protected]> Reviewed-by: Andrew Paseltiner <[email protected]> Reviewed-by: Avi Drissman <[email protected]> Commit-Queue: Nan Lin <[email protected]> Cr-Commit-Position: refs/heads/main@{#1268584} -- wpt-commits: 11df0cd533436c33c98299fd9a52e2393d1cf21f wpt-pr: 44904
jamienicol
pushed a commit
to jamienicol/gecko
that referenced
this pull request
Mar 17, 2024
…ttribution Reporting API, a=testonly Automatic update from web-platform-tests Support header error debug reports for Attribution Reporting API WICG/attribution-reporting-api#1180 This CL introduces a new mojo method in AttributionDataHost mojo interface to plumb the errors from header validation in the renderer to the browser. This is necessary as the permission check for debug reporting is performed in the browser, and also it helps to unify the code path for errors from header validation in the browser. Bug: 328043301 Change-Id: If8c0f1295dfc08d914138362c9275b0952b2e4b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5334963 Reviewed-by: Nate Chapin <[email protected]> Reviewed-by: Brendon Tiszka <[email protected]> Reviewed-by: Andrew Paseltiner <[email protected]> Reviewed-by: Avi Drissman <[email protected]> Commit-Queue: Nan Lin <[email protected]> Cr-Commit-Position: refs/heads/main@{#1268584} -- wpt-commits: 11df0cd533436c33c98299fd9a52e2393d1cf21f wpt-pr: 44904
BruceDai
pushed a commit
to BruceDai/wpt
that referenced
this pull request
Mar 25, 2024
WICG/attribution-reporting-api#1180 This CL introduces a new mojo method in AttributionDataHost mojo interface to plumb the errors from header validation in the renderer to the browser. This is necessary as the permission check for debug reporting is performed in the browser, and also it helps to unify the code path for errors from header validation in the browser. Bug: 328043301 Change-Id: If8c0f1295dfc08d914138362c9275b0952b2e4b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5334963 Reviewed-by: Nate Chapin <[email protected]> Reviewed-by: Brendon Tiszka <[email protected]> Reviewed-by: Andrew Paseltiner <[email protected]> Reviewed-by: Avi Drissman <[email protected]> Commit-Queue: Nan Lin <[email protected]> Cr-Commit-Position: refs/heads/main@{#1268584}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #801
Preview | Diff