Remove "impression"/"conversion" from API surfaces #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This updates the proposed API with the naming changes discussed on #57. This includes updating the reporting format to a JSON body with the new names
maudnals
reviewed
Feb 2, 2021
README.md
Outdated
|
|
||
| - **Conversion**: The completion of a meaningful (advertiser specified) user action on the advertiser's web site by a user who has previously interacted with an ad from that advertiser. | ||
|
|
||
| - **Event-level data**: Data that can be tied back to a specific low-level event; not aggregated | ||
|
|
||
| - **Click-through-conversion (CTC)**: A conversion credit attributed to an impression that was clicked | ||
| - **Click-through-conversion (CTC)**: A conversion attributed to an impression that was clicked |
There was a problem hiding this comment.
Option 1: s/impression/attribution source
Option 2: s/impression/ad click or view (feels clearer)
There was a problem hiding this comment.
I think it should be a goal to remove ads specific jargon in the explainer, except in a use-case section
There was a problem hiding this comment.
Went with "ad click" as this is specific for click-through
| ``` | ||
|
|
||
| Privacy Considerations | ||
| ====================== | ||
| The main privacy goal of the API is to make _linking identity_ between two different top-level sites difficult. This happens when either a request or a Javascript environment has two user IDs from two different sites simultaneously. | ||
|
|
||
| In this API, the 64-bit impression ID can encode a user ID from the publisher’s top level site, but the low entropy, noisy conversion data could only encode a small part of a user ID from the advertiser’s top-level site. The impression ID and the conversion data are never exposed to a Javascript environment together, and the request that includes both of them is sent without credentials and at a different time from either event, so the request adds little new information linkable to these events. | ||
| In this API, the 64-bit source ID can encode a user ID from the publisher’s top level site, but the low entropy, noisy trigger data could only encode a small part of a user ID from the advertiser’s top-level site. The source ID and the trigger data are never exposed to a Javascript environment together, and the request that includes both of them is sent without credentials and at a different time from either event, so the request adds little new information linkable to these events. |
Co-authored-by: Maud <[email protected]>
csharrison
reviewed
Feb 2, 2021
| @@ -55,13 +51,13 @@ Glossary | |||
|
|
|||
There was a problem hiding this comment.
IMO we are close to being able to remove the full Glossary. In a follow-up I believe we can remove any mention of publishers, advertisers, etc. from the explainer and having different terms for them (e.g. the attribution destination)
There was a problem hiding this comment.
Ack, that sounds like a good improvement will file an issue to clean this up
README.md
Outdated
|
|
||
| - **Conversion**: The completion of a meaningful (advertiser specified) user action on the advertiser's web site by a user who has previously interacted with an ad from that advertiser. | ||
|
|
||
| - **Event-level data**: Data that can be tied back to a specific low-level event; not aggregated | ||
|
|
||
| - **Click-through-conversion (CTC)**: A conversion credit attributed to an impression that was clicked | ||
| - **Click-through-conversion (CTC)**: A conversion attributed to an impression that was clicked |
There was a problem hiding this comment.
I think it should be a goal to remove ads specific jargon in the explainer, except in a use-case section
Co-authored-by: Maud <[email protected]>
Co-authored-by: Maud <[email protected]>
Co-authored-by: Maud <[email protected]>
Co-authored-by: Maud <[email protected]>
Co-authored-by: Maud <[email protected]>
Co-authored-by: Maud <[email protected]>
csharrison
reviewed
Feb 5, 2021
csharrison
approved these changes
Feb 8, 2021
johnivdel
added a commit
that referenced
this pull request
Apr 30, 2021
* Update spec to current explainer This updates the draft spec to include all changes which were landed to the explainer since it was last updated. This includes: - all naming changes on #103 and #121 - removal of hexadecimal encoding for data fields Algorithm definitions and variables are updated to reflect the new naming. * Update index.bs * Update index.bs * Update index.bs * Update index.bs * Update index.bs * Respond to review feedback * Apply suggestions from code review Co-authored-by: Jeffrey Yasskin <[email protected]> * Apply suggestions from code review Co-authored-by: Jeffrey Yasskin <[email protected]> * Update index.bs * Update index.bs Co-authored-by: Jeffrey Yasskin <[email protected]>
blueboxd
pushed a commit
to blueboxd/chromium-legacy
that referenced
this pull request
May 14, 2021
What: This change renames all web exposed surfaces to match the new Conversion Measurement API names in accordance with WICG/attribution-reporting-api#103 This does not change any internal names used for storing and propagating API data. Why: Without pausing the Origin Trial, is makes sense to make all of surface changes at once to minimize any risk of the API getting into an unexpected state due to reverts etc. The implementation names and structures will be updated in followups, which should be easier to review given that they will be pure structural changes. E.g. https://chromium-review.googlesource.com/c/chromium/src/+/2702912 The internals page title/url will be updated in a followup tracked by https://crbug.com/1165916 Bug: 1165916 Change-Id: Ie6d2a2d32324bdf90a74984d1fadc3f37b5a3301 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2706498 Commit-Queue: John Delaney <[email protected]> Reviewed-by: Robert Sesek <[email protected]> Reviewed-by: Charlie Harrison <[email protected]> Reviewed-by: Nate Chapin <[email protected]> Cr-Commit-Position: refs/heads/master@{#882974}
mjfroman
pushed a commit
to mjfroman/moz-libwebrtc-third-party
that referenced
this pull request
Oct 14, 2022
What: This change renames all web exposed surfaces to match the new Conversion Measurement API names in accordance with WICG/attribution-reporting-api#103 This does not change any internal names used for storing and propagating API data. Why: Without pausing the Origin Trial, is makes sense to make all of surface changes at once to minimize any risk of the API getting into an unexpected state due to reverts etc. The implementation names and structures will be updated in followups, which should be easier to review given that they will be pure structural changes. E.g. https://chromium-review.googlesource.com/c/chromium/src/+/2702912 The internals page title/url will be updated in a followup tracked by https://crbug.com/1165916 Bug: 1165916 Change-Id: Ie6d2a2d32324bdf90a74984d1fadc3f37b5a3301 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2706498 Commit-Queue: John Delaney <[email protected]> Reviewed-by: Robert Sesek <[email protected]> Reviewed-by: Charlie Harrison <[email protected]> Reviewed-by: Nate Chapin <[email protected]> Cr-Commit-Position: refs/heads/master@{#882974} NOKEYCHECK=True GitOrigin-RevId: 7a48dde0857eccf6f61397a962c8532869b861f2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the proposed API with the naming changes discussed on #57.
This includes updating the reporting format to a JSON body with the new names