Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove axios in favour of native in API docs #7312

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

alvinometric
Copy link
Contributor

@alvinometric alvinometric commented Jun 6, 2024

Massive thanks to @thomasheartman for digging around GitHub and figuring out how to do this.

Regrettably it doesn't use the native fetch, which is what I thought it would do. It's more code so I'm happy to close it but I still think it's worth the discussion

Before this PR:
image

After this PR:
image

Copy link

vercel bot commented Jun 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
unleash-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 6, 2024 5:28pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
unleash-monorepo-frontend ⬜️ Ignored (Inspect) Visit Preview Jun 6, 2024 5:28pm

Copy link

github-actions bot commented Jun 6, 2024

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Manifest Files

@alvinometric alvinometric changed the title Remove axios in favour of native fetch in API docs Remove axios in favour of native in API docs Jun 6, 2024
Copy link
Contributor

@thomasheartman thomasheartman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Yeah, it's more code, but it removes the axios dependency, so I'm in favor of it 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Approved PRs
Development

Successfully merging this pull request may close these issues.

None yet

2 participants