-
-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nixos/lib/make-ext4-fs: use mkfs.ext4 instead of cptofs #82718
Conversation
This should also fix building on
Before:
After:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome :)
I have successfully used this in conjunction with #86291 to cross-build an aarch64 image for a raspberry 3 via https://github.com/nix-community/nixos-generators (+ enabling
Can confirm that this change gets rid of the |
f192676
to
fd0fe4b
Compare
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
diff LGTM
would like to see what @samueldr has to say, especially with this work making mobile NixOS.
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
fd0fe4b
to
ff6354f
Compare
ff6354f
to
40ffbce
Compare
I poked @samueldr on IRC about reviewing this, and they said they would take a look |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor change and imo this can be merged to unstable then.
This fixes image creation on armv7l when image is bigger than 2G. Also fix some reproducibility issues and other cptofs issues.
40ffbce
to
9ac1ab1
Compare
Motivation for this change
When building big
sd-image
onarmv7l
cptofs is failing with this error:Fix this issue by dropping
cptofs
from script and using-d
argument ofmkfs.ext4
instead aslkl
is not maintained and takes a very long time to build.Also make image creation more reproducible.
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)cc @samueldr @grahamc