Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add support for spotify #29

Merged
merged 12 commits into from
Nov 11, 2019
Merged

feat: add support for spotify #29

merged 12 commits into from
Nov 11, 2019

Conversation

jyash97
Copy link
Contributor

@jyash97 jyash97 commented Oct 11, 2019 •
edited

What:
Add support for Spotify
Close #4

Why:

How:

Checklist:

  • Documentation
  • Tests
  • Ready to be merged

anuraghazra
anuraghazra reviewed Oct 11, 2019
View reviewed changes
src/Spotify.js Outdated Show resolved Hide resolved
@anuraghazra
Copy link
Contributor

allowing embedding tracks would be great to have i guess, 🤔
https://open.spotify.com/track/02itaCXOdC54J0ISjqqFAp

@MichaelDeBoey MichaelDeBoey added the ⚙️ Spotify Issue or pull request regarding Spotify label Oct 13, 2019
MichaelDeBoey
MichaelDeBoey requested changes Oct 16, 2019
View reviewed changes
Copy link
Owner

@MichaelDeBoey MichaelDeBoey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jyash97!

Thanks for taking your time to implement the Spotify transformer! 🙂
Really great work.

I've added some remarks on how we should take this transformer into the right direction.

Let me know if you need some further help. 🙂

src/Spotify.js Outdated Show resolved Hide resolved
src/Spotify.js Outdated Show resolved Hide resolved
src/__tests__/Spotify.js Outdated Show resolved Hide resolved
@MichaelDeBoey
Copy link
Owner

Please also rebase on latest master so you get the newest tests added in #27. 🙂

@jyash97
Copy link
Contributor Author

jyash97 commented Oct 17, 2019

Hey @MichaelDeBoey thanks for a quick review. The requested changes make sense to me. Will push those changes soon :)

@MichaelDeBoey
Copy link
Owner

@jyash97 Any progress on this one yet? 🤔

@jyash97
Copy link
Contributor Author

jyash97 commented Oct 23, 2019

Hey @MichaelDeBoey Currently swamped up with a lot of work. I did not got time to make the changes. I will try to by this week.

Sorry for the delay.

@MichaelDeBoey
Copy link
Owner

No problem, just wanted to check in on this one.
Would be awesome if we could get this one in. 🙂

jyash97
jyash97 commented Oct 26, 2019
View reviewed changes
src/Spotify.js Outdated Show resolved Hide resolved
@MichaelDeBoey MichaelDeBoey force-pushed the feat/spotify branch 2 times, most recently from e007959 to ac9a244 Compare October 29, 2019 17:21
MichaelDeBoey
MichaelDeBoey requested changes Oct 29, 2019
View reviewed changes
Copy link
Owner

@MichaelDeBoey MichaelDeBoey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work already @jyash97! 👊

I've rebased your branch onto upstream/master, did some small cleanups and updated the tests.
I also added some tests.

Tests are now good, so shouldn't be changed.
If you change the code so the tests pass, I think this can be merged 🙂

src/Spotify.js Outdated Show resolved Hide resolved
src/Spotify.js Outdated Show resolved Hide resolved
@MichaelDeBoey MichaelDeBoey self-assigned this Oct 29, 2019
@jyash97
Copy link
Contributor Author

jyash97 commented Nov 2, 2019

Hey, @MichaelDeBoey I have done the code changes. Only 2 test suites are failing and I am not good on tests so I am not able to figure that out.

Though I have done the code coverage to 100 and all tests are now passing. Thanks for the help 💯

MichaelDeBoey
MichaelDeBoey requested changes Nov 2, 2019
View reviewed changes
Copy link
Owner

@MichaelDeBoey MichaelDeBoey left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I rebased you branch onto upstream/master again, updated the snapshots and left you some comments on how I think you should fix the tests

src/Spotify.js Outdated Show resolved Hide resolved
src/Spotify.js Outdated Show resolved Hide resolved
@jyash97
Copy link
Contributor Author

jyash97 commented Nov 4, 2019

Hey @MichaelDeBoey Sorry for the delay in this PR and the conflict in code. My goal is to have this ready this week.

MichaelDeBoey
MichaelDeBoey requested changes Nov 10, 2019
View reviewed changes
Copy link
Owner

@MichaelDeBoey MichaelDeBoey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jyash97 Just some small adjustments and then this one can be merged 🙂

src/Spotify.js Outdated Show resolved Hide resolved
src/Spotify.js Outdated Show resolved Hide resolved
src/Spotify.js Show resolved Hide resolved
MichaelDeBoey
MichaelDeBoey approved these changes Nov 11, 2019
View reviewed changes
Copy link
Owner

@MichaelDeBoey MichaelDeBoey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking the time to implement the Spotify transformer @jyash97! 👊

@MichaelDeBoey MichaelDeBoey merged commit 55aa248 into MichaelDeBoey:master Nov 11, 2019
@MichaelDeBoey
Copy link
Owner

🎉 This PR is included in version 1.5.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@jyash97
Copy link
Contributor Author

jyash97 commented Nov 11, 2019

Awesome 💯

Glad to see the PR merged and released. Also sorry for the delay in getting the PR ready was caught with some work and CSB issues.

Thanks for the help! Got to learn few things :)

@MichaelDeBoey
Copy link
Owner

No problem at all @jyash97!

We all do OSS in our free time, so patience is key! 😉

@MichaelDeBoey
Copy link
Owner

@all-contributors Please add @jyash97 for code and tests

@allcontributors allcontributors bot mentioned this pull request Nov 11, 2019
Merged
@allcontributors
Copy link
Contributor

@MichaelDeBoey

I've put up a pull request to add @jyash97! 🎉

anuraghazra referenced this pull request in anuraghazra/gatsby-remark-embedder Feb 5, 2020
@jyash97 @anuraghazra
feat(Spotify): Add support for Spotify (#29)
35c432c 
* feat: add support for spotify

* Add docs & fix export

* fix: remove invalid URL

* feat: add support for embedding spotify track

* fix: add separate method for fetching Iframe url and more support of spotify url

* Cleanup docs

* Cleanup code

* Update + add tests

* fix: tests and refactor code

* Update snapshots

* fix: requested change

* fix: requested changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anuraghazra anuraghazra anuraghazra left review comments

@MichaelDeBoey MichaelDeBoey MichaelDeBoey approved these changes

Assignees

@MichaelDeBoey MichaelDeBoey

Labels
released ⚙️ Spotify Issue or pull request regarding Spotify
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support Spotify
3 participants
@jyash97 @anuraghazra @MichaelDeBoey