fix(show-me/crashreporter): refactor to use current Electron security…

… defaults (electron#899) Co-authored-by: Timothy Lim <[email protected]>
MaxMood96 · Nov 16, 2021 · 88d3471 · 88d3471
1 parent 831b978
commit 88d3471
Show file tree

Hide file tree

Showing 4 changed files with 15 additions and 17 deletions.
diff --git a/static/show-me/crashreporter/index.html b/static/show-me/crashreporter/index.html
@@ -5,8 +5,5 @@
 </head>
 <body>
  <h1>CrashReporter Demo</h1>
- <script>
- require('./renderer.js')
- </script>
 </body>
 </html>
diff --git a/static/show-me/crashreporter/main.js b/static/show-me/crashreporter/main.js
@@ -3,14 +3,24 @@
 // For more info, see:
 // https://electronjs.org/docs/api/crash-reporter
 
-const { app, BrowserWindow } = require('electron')
+const { app, BrowserWindow, crashReporter } = require('electron')
+const path = require('path')
+
+crashReporter.start({
+ productName: 'YourName',
+ companyName: 'YourCompany',
+ submitURL: 'https://your-domain.com/url-to-submit',
+ uploadToServer: true
+})
 
 app.whenReady().then(() => {
  const mainWindow = new BrowserWindow({
  height: 600,
  width: 600,
  webPreferences: {
- nodeIntegration: true
+ nodeIntegration: false, // default in Electron >= 5
+ contextIsolation: true, // default in Electron >= 12
+ preload: path.join(__dirname, 'preload.js')
  }
  })
  mainWindow.loadFile('index.html')

diff --git a/static/show-me/crashreporter/preload.js b/static/show-me/crashreporter/preload.js
@@ -0,0 +1,3 @@
+setTimeout(() => {
+ process.crash()
+}, 2000)
diff --git a/static/show-me/crashreporter/renderer.js b/static/show-me/crashreporter/renderer.js