Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add information about Kotlin libraries and compiler plugins to K2 migration guide #4289

Merged
merged 1 commit into from
Jun 13, 2024
Merged

Add information about Kotlin libraries and compiler plugins to K2 migration guide #4289

merged 1 commit into from
Jun 13, 2024

Conversation

sarahhaggarty
Copy link
Collaborator

This PR adds information about how the K2 compiler works with Kotlin libraries and compiler plugins to the K2 compiler migration guide.

@sarahhaggarty sarahhaggarty requested a review from a team as a code owner June 13, 2024 07:45
@daniCsorbaJB daniCsorbaJB self-requested a review June 13, 2024 08:00
daniCsorbaJB
daniCsorbaJB approved these changes Jun 13, 2024
View reviewed changes
Copy link
Contributor

@daniCsorbaJB daniCsorbaJB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀 - I added one small proposal, but it's just a matter of preference.

docs/topics/k2-compiler-migration-guide.md Outdated Show resolved Hide resolved
@sarahhaggarty sarahhaggarty force-pushed the k2-lib-plugins branch 2 times, most recently from 695e580 to da8755b Compare June 13, 2024 08:24
@sarahhaggarty sarahhaggarty merged commit 3515d48 into master Jun 13, 2024
3 checks passed
@sarahhaggarty sarahhaggarty deleted the k2-lib-plugins branch June 13, 2024 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daniCsorbaJB daniCsorbaJB daniCsorbaJB approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@sarahhaggarty @daniCsorbaJB