deps: upgrade trace_engine and drop manually written types #15810
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
connorjclark
commented
Feb 15, 2024
| )); | ||
| // TODO: use TraceEngine.TraceProcessor.createWithAllHandlers above. | ||
| return /** @type {import('@paulirish/trace_engine').Handlers.Types.TraceParseData} */( | ||
| engine.data); |
There was a problem hiding this comment.
I will follow up with this change. Didn't want a behavior change with this patch.
paulirish
reviewed
Feb 15, 2024
| await engine.parse(/** @type {import('@paulirish/trace_engine').Types.TraceEvents.TraceEventData[]} */ ( | ||
| traceEvents | ||
| )); | ||
| // TODO: use TraceEngine.TraceProcessor.createWithAllHandlers above. |
There was a problem hiding this comment.
relevant chat thread:
shrugz.
paulirish
approved these changes
Feb 15, 2024
adamraine
approved these changes
Feb 15, 2024
core/gather/gatherers/root-causes.js
Outdated
| } | ||
| }, | ||
| /** @param {string} url */ | ||
| // @ts-expect-error |
There was a problem hiding this comment.
nit: can you add a comment explaining this @ts-expect-error
connorjclark
commented
Feb 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We modified the trace_engine lib to publish many JS files instead of bundling, so we could easily package types. Can now delete
types/trace-engine.d.ts.Some churn, it comes from the trace event types being less ergonomic than our own. Also from more specific types than what I wrote manually.