Add Canva website-v2 template #541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Linter OK: |
|
This is now ready for review, thanks in advance! |
pawel-kow
reviewed
Jun 14, 2024
pawel-kow
approved these changes
Jun 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
This PR adds a
canva.com.website-v2.jsontemplate, which builds on canva.com.website.json but introduces breaking changes. A new template is being introduced based on advice in the Spec here.More context / discussion: #483
This template allows us to:
@)groupIds to allow setting hosting records (A records), TXT, or CNAME verification records separatelyExamples
_verify.example.com->123.canva.comdomain=example.com&verify-cname-name=_verify&verify-cname-value=123.canva.com&groupId=hostingA,verificationCname@->verify=123domain=example.com&verify-txt-value=verify%3D123&groupId=hostingA,verificationTxt****Using
%3Das the=symbol.Test
Using https://pdnsadmin.revproxy.short-lived.de/dc/free/templateedit#tbl_records_and_errors