Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

arm build not hermetic nm #766

Closed
nickdesaulniers opened this issue Nov 6, 2019 · 10 comments
Closed

arm build not hermetic nm #766

nickdesaulniers opened this issue Nov 6, 2019 · 10 comments
Assignees
@tpimh
Labels
[ARCH] arm32 This bug impacts ARCH=arm [BUG] linux A bug that should be fixed in the mainline kernel. [FIXED][LINUX] 5.5 This bug was fixed in Linux 5.5 [TOOL] llvm-nm The issue is relevant to LLVM nm

Comments

@nickdesaulniers
Copy link
Member

@tpimh points out that the arm32 build isn't hermetic.

Let's find and fix that.
@nickdesaulniers nickdesaulniers added good first issue Good for newcomers [BUG] linux A bug that should be fixed in the mainline kernel. [ARCH] arm32 This bug impacts ARCH=arm labels Nov 6, 2019
@nickdesaulniers nickdesaulniers mentioned this issue Nov 6, 2019
Open
@nickdesaulniers
Copy link
Member Author

Looks like nm is hard coded https://github.com/ClangBuiltLinux/linux/blob/master/arch/arm/boot/compressed/Makefile#L124 and https://github.com/ClangBuiltLinux/linux/blob/master/arch/arm/boot/compressed/Makefile#L168. These should likely be $(NM) which is set correctly for cross compiling by the top level Makefile.

@nickdesaulniers nickdesaulniers added the [TOOL] llvm-nm The issue is relevant to LLVM nm label Nov 6, 2019
@nickdesaulniers
Copy link
Member Author

cc @metti

@tpimh
Copy link

tpimh commented Nov 6, 2019

Thank you for finding where nm is used. Just replacing with correct variable fixes the build:

--- a/arch/arm/boot/compressed/Makefile
+++ b/arch/arm/boot/compressed/Makefile
@@ -121,7 +121,7 @@ ccflags-y := -fpic $(call cc-option,-mno-single-pic-base,) -fno-builtin -I$(obj)
 asflags-y := -DZIMAGE
 
 # Supply kernel BSS size to the decompressor via a linker symbol.
-KBSS_SZ = $(shell echo $$(($$($(CROSS_COMPILE)nm $(obj)/../../../../vmlinux | \
+KBSS_SZ = $(shell echo $$(($$($(NM) $(obj)/../../../../vmlinux | \
 		sed -n -e 's/^\([^ ]*\) [AB] __bss_start$$/-0x\1/p' \
 		       -e 's/^\([^ ]*\) [AB] __bss_stop$$/+0x\1/p') )) )
 LDFLAGS_vmlinux = --defsym _kernel_bss_size=$(KBSS_SZ)
@@ -165,7 +165,7 @@ $(obj)/bswapsdi2.S: $(srctree)/arch/$(SRCARCH)/lib/bswapsdi2.S
 # The .data section is already discarded by the linker script so no need
 # to bother about it here.
 check_for_bad_syms = \
-bad_syms=$$($(CROSS_COMPILE)nm $@ | sed -n 's/^.\{8\} [bc] \(.*\)/\1/p') && \
+bad_syms=$$($(NM) $@ | sed -n 's/^.\{8\} [bc] \(.*\)/\1/p') && \
 [ -z "$$bad_syms" ] || \
   ( echo "following symbols must have non local/private scope:" >&2; \
     echo "$$bad_syms" >&2; false )

@tpimh tpimh added the [PATCH] Exists There is a patch that fixes this issue label Nov 6, 2019
@nickdesaulniers
Copy link
Member Author

@tpimh can you please send that to lkml?

@tpimh
Copy link

tpimh commented Nov 6, 2019

I can do it on this weekend. If you want to submit it sooner, feel free.

@tpimh tpimh self-assigned this Nov 6, 2019
@tpimh
Copy link

tpimh commented Nov 10, 2019 •
edited by nathanchance
Loading

https://lore.kernel.org/r/[email protected]/
Please, correct me if I did something wrong.

@tpimh tpimh added [PATCH] Submitted A patch has been submitted for review and removed [PATCH] Exists There is a patch that fixes this issue good first issue Good for newcomers labels Nov 10, 2019
@tpimh tpimh mentioned this issue Nov 12, 2019
Closed
fengguang pushed a commit to 0day-ci/linux that referenced this issue Nov 12, 2019
@tpimh @intel-lab-lkp
ARM: kbuild: use correct nm executable
f4fca85 
Since $(NM) variable can be easily overridden for the whole build, it's
better to use it instead of $(CROSS_COMPILE)nm. The use of $(CROSS_COMPILE)
prefixed variables where their calculated equivalents can be used is
incorrect. This fixes issues with builds where $(NM) is set to llvm-nm.

Link: ClangBuiltLinux#766
Signed-off-by: Dmitry Golovin <[email protected]>
Suggested-by: Nick Desaulniers <[email protected]>
Cc: Matthias Maennich <[email protected]>
@nickdesaulniers
Copy link
Member Author

nickdesaulniers commented Nov 19, 2019 •
edited by nathanchance
Loading

should be good to submit it to rmk's q

@tpimh
Copy link

tpimh commented Nov 19, 2019

I tried creating an account at armlinux.org.uk yesterday and failed. I get an email with a password in my inbox, but when I try to use it to log in, it doesn't accept it. So I emailed [email protected] about my problem, no reply yet.

@tpimh
Copy link

tpimh commented Nov 19, 2019

With the registration fixed, I finally submitted the patch: https://www.armlinux.org.uk/developer/patches/viewpatch.php?id=8939/1

fengguang pushed a commit to 0day-ci/linux that referenced this issue Nov 22, 2019
@tpimh
ARM: 8939/1: kbuild: use correct nm executable
29c623d 
Since $(NM) variable can be easily overridden for the whole build, it's
better to use it instead of $(CROSS_COMPILE)nm. The use of $(CROSS_COMPILE)
prefixed variables where their calculated equivalents can be used is
incorrect. This fixes issues with builds where $(NM) is set to llvm-nm.

Link: ClangBuiltLinux#766

Signed-off-by: Dmitry Golovin <[email protected]>
Suggested-by: Nick Desaulniers <[email protected]>
Cc: Matthias Maennich <[email protected]>
Reviewed-by: Nathan Chancellor <[email protected]>
Tested-by: Nathan Chancellor <[email protected]>
Reviewed-by: Masahiro Yamada <[email protected]>
Reviewed-by: Nick Desaulniers <[email protected]>
Signed-off-by: Russell King <[email protected]>
@nathanchance
Copy link
Member

Merged into mainline: https://git.kernel.org/linus/29c623d64f0dcd6aa10e0eabd16233e77114090b

@nathanchance nathanchance added [FIXED][LINUX] 5.5 This bug was fixed in Linux 5.5 and removed [PATCH] Submitted A patch has been submitted for review labels Dec 1, 2019
nathanchance pushed a commit to nathanchance/pi-kernel that referenced this issue May 12, 2020
@tpimh @nathanchance
ARM: 8939/1: kbuild: use correct nm executable
3f187d4 
Since $(NM) variable can be easily overridden for the whole build, it's
better to use it instead of $(CROSS_COMPILE)nm. The use of $(CROSS_COMPILE)
prefixed variables where their calculated equivalents can be used is
incorrect. This fixes issues with builds where $(NM) is set to llvm-nm.

Link: ClangBuiltLinux/linux#766

Signed-off-by: Dmitry Golovin <[email protected]>
Suggested-by: Nick Desaulniers <[email protected]>
Cc: Matthias Maennich <[email protected]>
Reviewed-by: Nathan Chancellor <[email protected]>
Tested-by: Nathan Chancellor <[email protected]>
Reviewed-by: Masahiro Yamada <[email protected]>
Reviewed-by: Nick Desaulniers <[email protected]>
Signed-off-by: Russell King <[email protected]>
Link: https://git.kernel.org/linus/29c623d64f0dcd6aa10e0eabd16233e77114090b
Signed-off-by: Nathan Chancellor <[email protected]>
nathanchance pushed a commit to nathanchance/pi-kernel that referenced this issue May 21, 2020
@tpimh @nathanchance
ARM: 8939/1: kbuild: use correct nm executable
d5d1e44 
Since $(NM) variable can be easily overridden for the whole build, it's
better to use it instead of $(CROSS_COMPILE)nm. The use of $(CROSS_COMPILE)
prefixed variables where their calculated equivalents can be used is
incorrect. This fixes issues with builds where $(NM) is set to llvm-nm.

Link: ClangBuiltLinux/linux#766

Signed-off-by: Dmitry Golovin <[email protected]>
Suggested-by: Nick Desaulniers <[email protected]>
Cc: Matthias Maennich <[email protected]>
Reviewed-by: Nathan Chancellor <[email protected]>
Tested-by: Nathan Chancellor <[email protected]>
Reviewed-by: Masahiro Yamada <[email protected]>
Reviewed-by: Nick Desaulniers <[email protected]>
Signed-off-by: Russell King <[email protected]>
Link: https://git.kernel.org/linus/29c623d64f0dcd6aa10e0eabd16233e77114090b
Signed-off-by: Nathan Chancellor <[email protected]>
nathanchance pushed a commit to nathanchance/pi-kernel that referenced this issue Jun 12, 2020
@tpimh @nathanchance
ARM: 8939/1: kbuild: use correct nm executable
8253057 
Since $(NM) variable can be easily overridden for the whole build, it's
better to use it instead of $(CROSS_COMPILE)nm. The use of $(CROSS_COMPILE)
prefixed variables where their calculated equivalents can be used is
incorrect. This fixes issues with builds where $(NM) is set to llvm-nm.

Link: ClangBuiltLinux/linux#766

Signed-off-by: Dmitry Golovin <[email protected]>
Suggested-by: Nick Desaulniers <[email protected]>
Cc: Matthias Maennich <[email protected]>
Reviewed-by: Nathan Chancellor <[email protected]>
Tested-by: Nathan Chancellor <[email protected]>
Reviewed-by: Masahiro Yamada <[email protected]>
Reviewed-by: Nick Desaulniers <[email protected]>
Signed-off-by: Russell King <[email protected]>
Link: https://git.kernel.org/linus/29c623d64f0dcd6aa10e0eabd16233e77114090b
Signed-off-by: Nathan Chancellor <[email protected]>
nathanchance pushed a commit to nathanchance/pi-kernel that referenced this issue Jun 24, 2020
@tpimh @nathanchance
ARM: 8939/1: kbuild: use correct nm executable
367e127 
Since $(NM) variable can be easily overridden for the whole build, it's
better to use it instead of $(CROSS_COMPILE)nm. The use of $(CROSS_COMPILE)
prefixed variables where their calculated equivalents can be used is
incorrect. This fixes issues with builds where $(NM) is set to llvm-nm.

Link: ClangBuiltLinux/linux#766

Signed-off-by: Dmitry Golovin <[email protected]>
Suggested-by: Nick Desaulniers <[email protected]>
Cc: Matthias Maennich <[email protected]>
Reviewed-by: Nathan Chancellor <[email protected]>
Tested-by: Nathan Chancellor <[email protected]>
Reviewed-by: Masahiro Yamada <[email protected]>
Reviewed-by: Nick Desaulniers <[email protected]>
Signed-off-by: Russell King <[email protected]>
Link: https://git.kernel.org/linus/29c623d64f0dcd6aa10e0eabd16233e77114090b
Signed-off-by: Nathan Chancellor <[email protected]>
nathanchance pushed a commit to nathanchance/pi-kernel that referenced this issue Jul 10, 2020
@tpimh @nathanchance
ARM: 8939/1: kbuild: use correct nm executable
f915852 
Since $(NM) variable can be easily overridden for the whole build, it's
better to use it instead of $(CROSS_COMPILE)nm. The use of $(CROSS_COMPILE)
prefixed variables where their calculated equivalents can be used is
incorrect. This fixes issues with builds where $(NM) is set to llvm-nm.

Link: ClangBuiltLinux/linux#766

Signed-off-by: Dmitry Golovin <[email protected]>
Suggested-by: Nick Desaulniers <[email protected]>
Cc: Matthias Maennich <[email protected]>
Reviewed-by: Nathan Chancellor <[email protected]>
Tested-by: Nathan Chancellor <[email protected]>
Reviewed-by: Masahiro Yamada <[email protected]>
Reviewed-by: Nick Desaulniers <[email protected]>
Signed-off-by: Russell King <[email protected]>
Link: https://git.kernel.org/linus/29c623d64f0dcd6aa10e0eabd16233e77114090b
Signed-off-by: Nathan Chancellor <[email protected]>
nathanchance pushed a commit to nathanchance/pi-kernel that referenced this issue Jul 20, 2020
@tpimh @nathanchance
ARM: 8939/1: kbuild: use correct nm executable
8ee5b6d 
Since $(NM) variable can be easily overridden for the whole build, it's
better to use it instead of $(CROSS_COMPILE)nm. The use of $(CROSS_COMPILE)
prefixed variables where their calculated equivalents can be used is
incorrect. This fixes issues with builds where $(NM) is set to llvm-nm.

Link: ClangBuiltLinux/linux#766

Signed-off-by: Dmitry Golovin <[email protected]>
Suggested-by: Nick Desaulniers <[email protected]>
Cc: Matthias Maennich <[email protected]>
Reviewed-by: Nathan Chancellor <[email protected]>
Tested-by: Nathan Chancellor <[email protected]>
Reviewed-by: Masahiro Yamada <[email protected]>
Reviewed-by: Nick Desaulniers <[email protected]>
Signed-off-by: Russell King <[email protected]>
Link: https://git.kernel.org/linus/29c623d64f0dcd6aa10e0eabd16233e77114090b
Signed-off-by: Nathan Chancellor <[email protected]>
woodsts pushed a commit to woodsts/linux-stable that referenced this issue Oct 17, 2020
@tpimh @gregkh
ARM: 8939/1: kbuild: use correct nm executable
444a6d0 
[ Upstream commit 29c623d ]

Since $(NM) variable can be easily overridden for the whole build, it's
better to use it instead of $(CROSS_COMPILE)nm. The use of $(CROSS_COMPILE)
prefixed variables where their calculated equivalents can be used is
incorrect. This fixes issues with builds where $(NM) is set to llvm-nm.

Link: ClangBuiltLinux/linux#766

Signed-off-by: Dmitry Golovin <[email protected]>
Suggested-by: Nick Desaulniers <[email protected]>
Cc: Matthias Maennich <[email protected]>
Reviewed-by: Nathan Chancellor <[email protected]>
Tested-by: Nathan Chancellor <[email protected]>
Reviewed-by: Masahiro Yamada <[email protected]>
Reviewed-by: Nick Desaulniers <[email protected]>
Signed-off-by: Russell King <[email protected]>
Signed-off-by: Sasha Levin <[email protected]>
woodsts pushed a commit to woodsts/linux-stable that referenced this issue Oct 17, 2020
@tpimh @gregkh
ARM: 8939/1: kbuild: use correct nm executable
30ddaa4 
[ Upstream commit 29c623d ]

Since $(NM) variable can be easily overridden for the whole build, it's
better to use it instead of $(CROSS_COMPILE)nm. The use of $(CROSS_COMPILE)
prefixed variables where their calculated equivalents can be used is
incorrect. This fixes issues with builds where $(NM) is set to llvm-nm.

Link: ClangBuiltLinux/linux#766

Signed-off-by: Dmitry Golovin <[email protected]>
Suggested-by: Nick Desaulniers <[email protected]>
Cc: Matthias Maennich <[email protected]>
Reviewed-by: Nathan Chancellor <[email protected]>
Tested-by: Nathan Chancellor <[email protected]>
Reviewed-by: Masahiro Yamada <[email protected]>
Reviewed-by: Nick Desaulniers <[email protected]>
Signed-off-by: Russell King <[email protected]>
Signed-off-by: Sasha Levin <[email protected]>
miraclestars pushed a commit to miraclestars/android_kernel_samsung_sm8250 that referenced this issue Oct 17, 2020
@tpimh @miraclestars
ARM: 8939/1: kbuild: use correct nm executable
183f04b 
[ Upstream commit 29c623d64f0dcd6aa10e0eabd16233e77114090b ]

Since $(NM) variable can be easily overridden for the whole build, it's
better to use it instead of $(CROSS_COMPILE)nm. The use of $(CROSS_COMPILE)
prefixed variables where their calculated equivalents can be used is
incorrect. This fixes issues with builds where $(NM) is set to llvm-nm.

Link: ClangBuiltLinux/linux#766

Signed-off-by: Dmitry Golovin <[email protected]>
Suggested-by: Nick Desaulniers <[email protected]>
Cc: Matthias Maennich <[email protected]>
Reviewed-by: Nathan Chancellor <[email protected]>
Tested-by: Nathan Chancellor <[email protected]>
Reviewed-by: Masahiro Yamada <[email protected]>
Reviewed-by: Nick Desaulniers <[email protected]>
Signed-off-by: Russell King <[email protected]>
Signed-off-by: Sasha Levin <[email protected]>
mrchapp pushed a commit to mrchapp/linux that referenced this issue Oct 18, 2020
@tpimh @gregkh
ARM: 8939/1: kbuild: use correct nm executable
58ceab6 
[ Upstream commit 29c623d ]

Since $(NM) variable can be easily overridden for the whole build, it's
better to use it instead of $(CROSS_COMPILE)nm. The use of $(CROSS_COMPILE)
prefixed variables where their calculated equivalents can be used is
incorrect. This fixes issues with builds where $(NM) is set to llvm-nm.

Link: ClangBuiltLinux#766

Signed-off-by: Dmitry Golovin <[email protected]>
Suggested-by: Nick Desaulniers <[email protected]>
Cc: Matthias Maennich <[email protected]>
Reviewed-by: Nathan Chancellor <[email protected]>
Tested-by: Nathan Chancellor <[email protected]>
Reviewed-by: Masahiro Yamada <[email protected]>
Reviewed-by: Nick Desaulniers <[email protected]>
Signed-off-by: Russell King <[email protected]>
Signed-off-by: Sasha Levin <[email protected]>
it-is-a-robot pushed a commit to openeuler-mirror/kernel that referenced this issue Oct 26, 2020
@tpimh
ARM: 8939/1: kbuild: use correct nm executable
c7b3d81 
[ Upstream commit 29c623d ]

Since $(NM) variable can be easily overridden for the whole build, it's
better to use it instead of $(CROSS_COMPILE)nm. The use of $(CROSS_COMPILE)
prefixed variables where their calculated equivalents can be used is
incorrect. This fixes issues with builds where $(NM) is set to llvm-nm.

Link: ClangBuiltLinux/linux#766

Signed-off-by: Dmitry Golovin <[email protected]>
Suggested-by: Nick Desaulniers <[email protected]>
Cc: Matthias Maennich <[email protected]>
Reviewed-by: Nathan Chancellor <[email protected]>
Tested-by: Nathan Chancellor <[email protected]>
Reviewed-by: Masahiro Yamada <[email protected]>
Reviewed-by: Nick Desaulniers <[email protected]>
Signed-off-by: Russell King <[email protected]>
Signed-off-by: Sasha Levin <[email protected]>
Signed-off-by: Yang Yingliang <[email protected]>
gibsson pushed a commit to boundarydevices/linux that referenced this issue Oct 28, 2020
@tpimh @gibsson
ARM: 8939/1: kbuild: use correct nm executable
c749753 
[ Upstream commit 29c623d ]

Since $(NM) variable can be easily overridden for the whole build, it's
better to use it instead of $(CROSS_COMPILE)nm. The use of $(CROSS_COMPILE)
prefixed variables where their calculated equivalents can be used is
incorrect. This fixes issues with builds where $(NM) is set to llvm-nm.

Link: ClangBuiltLinux/linux#766

Signed-off-by: Dmitry Golovin <[email protected]>
Suggested-by: Nick Desaulniers <[email protected]>
Cc: Matthias Maennich <[email protected]>
Reviewed-by: Nathan Chancellor <[email protected]>
Tested-by: Nathan Chancellor <[email protected]>
Reviewed-by: Masahiro Yamada <[email protected]>
Reviewed-by: Nick Desaulniers <[email protected]>
Signed-off-by: Russell King <[email protected]>
Signed-off-by: Sasha Levin <[email protected]>
miraclestars pushed a commit to miraclestars/android_kernel_samsung_sm8250 that referenced this issue Nov 2, 2020
@tpimh @miraclestars
ARM: 8939/1: kbuild: use correct nm executable
f1668f6 
[ Upstream commit 29c623d64f0dcd6aa10e0eabd16233e77114090b ]

Since $(NM) variable can be easily overridden for the whole build, it's
better to use it instead of $(CROSS_COMPILE)nm. The use of $(CROSS_COMPILE)
prefixed variables where their calculated equivalents can be used is
incorrect. This fixes issues with builds where $(NM) is set to llvm-nm.

Link: ClangBuiltLinux/linux#766

Signed-off-by: Dmitry Golovin <[email protected]>
Suggested-by: Nick Desaulniers <[email protected]>
Cc: Matthias Maennich <[email protected]>
Reviewed-by: Nathan Chancellor <[email protected]>
Tested-by: Nathan Chancellor <[email protected]>
Reviewed-by: Masahiro Yamada <[email protected]>
Reviewed-by: Nick Desaulniers <[email protected]>
Signed-off-by: Russell King <[email protected]>
Signed-off-by: Sasha Levin <[email protected]>
pmatos pushed a commit to pmatos/ubuntu-focal that referenced this issue Nov 25, 2020
@tpimh @smb49
ARM: 8939/1: kbuild: use correct nm executable
3496b9c 
BugLink: https://bugs.launchpad.net/bugs/1902111

[ Upstream commit 29c623d64f0dcd6aa10e0eabd16233e77114090b ]

Since $(NM) variable can be easily overridden for the whole build, it's
better to use it instead of $(CROSS_COMPILE)nm. The use of $(CROSS_COMPILE)
prefixed variables where their calculated equivalents can be used is
incorrect. This fixes issues with builds where $(NM) is set to llvm-nm.

Link: ClangBuiltLinux/linux#766

Signed-off-by: Dmitry Golovin <[email protected]>
Suggested-by: Nick Desaulniers <[email protected]>
Cc: Matthias Maennich <[email protected]>
Reviewed-by: Nathan Chancellor <[email protected]>
Tested-by: Nathan Chancellor <[email protected]>
Reviewed-by: Masahiro Yamada <[email protected]>
Reviewed-by: Nick Desaulniers <[email protected]>
Signed-off-by: Russell King <[email protected]>
Signed-off-by: Sasha Levin <[email protected]>
Signed-off-by: Kamal Mostafa <[email protected]>
Signed-off-by: Ian May <[email protected]>
jpuhlman pushed a commit to MontaVista-OpenSourceTechnology/linux-mvista that referenced this issue Dec 17, 2020
@tpimh @mvakuster
ARM: 8939/1: kbuild: use correct nm executable
7ee2025 
Source: Kernel.org
MR: 107372
Type: Integration
Disposition: Backport from git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable linux-4.19.y
ChangeID: 444a6d0fe930838444abf7c9ff5175f93e1a5d72
Description:

[ Upstream commit 29c623d ]

Since $(NM) variable can be easily overridden for the whole build, it's
better to use it instead of $(CROSS_COMPILE)nm. The use of $(CROSS_COMPILE)
prefixed variables where their calculated equivalents can be used is
incorrect. This fixes issues with builds where $(NM) is set to llvm-nm.

Link: ClangBuiltLinux/linux#766

Signed-off-by: Dmitry Golovin <[email protected]>
Suggested-by: Nick Desaulniers <[email protected]>
Cc: Matthias Maennich <[email protected]>
Reviewed-by: Nathan Chancellor <[email protected]>
Tested-by: Nathan Chancellor <[email protected]>
Reviewed-by: Masahiro Yamada <[email protected]>
Reviewed-by: Nick Desaulniers <[email protected]>
Signed-off-by: Russell King <[email protected]>
Signed-off-by: Sasha Levin <[email protected]>
Signed-off-by: Armin Kuster <[email protected]>
freeza-inc pushed a commit to freeza-inc/bm-galaxy-s20-ultra-snap-r that referenced this issue Dec 25, 2020
@tpimh @freeza-inc
ARM: 8939/1: kbuild: use correct nm executable
a7d5df0 
[ Upstream commit 29c623d64f0dcd6aa10e0eabd16233e77114090b ]

Since $(NM) variable can be easily overridden for the whole build, it's
better to use it instead of $(CROSS_COMPILE)nm. The use of $(CROSS_COMPILE)
prefixed variables where their calculated equivalents can be used is
incorrect. This fixes issues with builds where $(NM) is set to llvm-nm.

Link: ClangBuiltLinux/linux#766

Signed-off-by: Dmitry Golovin <[email protected]>
Suggested-by: Nick Desaulniers <[email protected]>
Cc: Matthias Maennich <[email protected]>
Reviewed-by: Nathan Chancellor <[email protected]>
Tested-by: Nathan Chancellor <[email protected]>
Reviewed-by: Masahiro Yamada <[email protected]>
Reviewed-by: Nick Desaulniers <[email protected]>
Signed-off-by: Russell King <[email protected]>
Signed-off-by: Sasha Levin <[email protected]>
miraclestars pushed a commit to miraclestars/android_kernel_samsung_sm8250 that referenced this issue Jan 2, 2021
@tpimh @miraclestars
ARM: 8939/1: kbuild: use correct nm executable
2cd8db0 
[ Upstream commit 29c623d64f0dcd6aa10e0eabd16233e77114090b ]

Since $(NM) variable can be easily overridden for the whole build, it's
better to use it instead of $(CROSS_COMPILE)nm. The use of $(CROSS_COMPILE)
prefixed variables where their calculated equivalents can be used is
incorrect. This fixes issues with builds where $(NM) is set to llvm-nm.

Link: ClangBuiltLinux/linux#766

Signed-off-by: Dmitry Golovin <[email protected]>
Suggested-by: Nick Desaulniers <[email protected]>
Cc: Matthias Maennich <[email protected]>
Reviewed-by: Nathan Chancellor <[email protected]>
Tested-by: Nathan Chancellor <[email protected]>
Reviewed-by: Masahiro Yamada <[email protected]>
Reviewed-by: Nick Desaulniers <[email protected]>
Signed-off-by: Russell King <[email protected]>
Signed-off-by: Sasha Levin <[email protected]>
miraclestars pushed a commit to miraclestars/android_kernel_samsung_sm8250 that referenced this issue Jan 2, 2021
@tpimh @miraclestars
ARM: 8939/1: kbuild: use correct nm executable
23e8183 
[ Upstream commit 29c623d64f0dcd6aa10e0eabd16233e77114090b ]

Since $(NM) variable can be easily overridden for the whole build, it's
better to use it instead of $(CROSS_COMPILE)nm. The use of $(CROSS_COMPILE)
prefixed variables where their calculated equivalents can be used is
incorrect. This fixes issues with builds where $(NM) is set to llvm-nm.

Link: ClangBuiltLinux/linux#766

Signed-off-by: Dmitry Golovin <[email protected]>
Suggested-by: Nick Desaulniers <[email protected]>
Cc: Matthias Maennich <[email protected]>
Reviewed-by: Nathan Chancellor <[email protected]>
Tested-by: Nathan Chancellor <[email protected]>
Reviewed-by: Masahiro Yamada <[email protected]>
Reviewed-by: Nick Desaulniers <[email protected]>
Signed-off-by: Russell King <[email protected]>
Signed-off-by: Sasha Levin <[email protected]>
miraclestars pushed a commit to miraclestars/android_kernel_samsung_sm8250 that referenced this issue Jan 2, 2021
@tpimh @miraclestars
ARM: 8939/1: kbuild: use correct nm executable
912c487 
[ Upstream commit 29c623d64f0dcd6aa10e0eabd16233e77114090b ]

Since $(NM) variable can be easily overridden for the whole build, it's
better to use it instead of $(CROSS_COMPILE)nm. The use of $(CROSS_COMPILE)
prefixed variables where their calculated equivalents can be used is
incorrect. This fixes issues with builds where $(NM) is set to llvm-nm.

Link: ClangBuiltLinux/linux#766

Signed-off-by: Dmitry Golovin <[email protected]>
Suggested-by: Nick Desaulniers <[email protected]>
Cc: Matthias Maennich <[email protected]>
Reviewed-by: Nathan Chancellor <[email protected]>
Tested-by: Nathan Chancellor <[email protected]>
Reviewed-by: Masahiro Yamada <[email protected]>
Reviewed-by: Nick Desaulniers <[email protected]>
Signed-off-by: Russell King <[email protected]>
Signed-off-by: Sasha Levin <[email protected]>
Jimbo77 pushed a commit to Jimbo77/Jimbok_common_sm8250-R that referenced this issue Jan 17, 2021
@tpimh @Jimbo77
ARM: 8939/1: kbuild: use correct nm executable
0417290 
[ Upstream commit 29c623d64f0dcd6aa10e0eabd16233e77114090b ]

Since $(NM) variable can be easily overridden for the whole build, it's
better to use it instead of $(CROSS_COMPILE)nm. The use of $(CROSS_COMPILE)
prefixed variables where their calculated equivalents can be used is
incorrect. This fixes issues with builds where $(NM) is set to llvm-nm.

Link: ClangBuiltLinux/linux#766

Signed-off-by: Dmitry Golovin <[email protected]>
Suggested-by: Nick Desaulniers <[email protected]>
Cc: Matthias Maennich <[email protected]>
Reviewed-by: Nathan Chancellor <[email protected]>
Tested-by: Nathan Chancellor <[email protected]>
Reviewed-by: Masahiro Yamada <[email protected]>
Reviewed-by: Nick Desaulniers <[email protected]>
Signed-off-by: Russell King <[email protected]>
Signed-off-by: Sasha Levin <[email protected]>
wh0dat pushed a commit to Jimbo77/Jimbok_common_sm8250-R that referenced this issue Jan 21, 2021
@tpimh @wh0dat
ARM: 8939/1: kbuild: use correct nm executable
458952c 
[ Upstream commit 29c623d64f0dcd6aa10e0eabd16233e77114090b ]

Since $(NM) variable can be easily overridden for the whole build, it's
better to use it instead of $(CROSS_COMPILE)nm. The use of $(CROSS_COMPILE)
prefixed variables where their calculated equivalents can be used is
incorrect. This fixes issues with builds where $(NM) is set to llvm-nm.

Link: ClangBuiltLinux/linux#766

Signed-off-by: Dmitry Golovin <[email protected]>
Suggested-by: Nick Desaulniers <[email protected]>
Cc: Matthias Maennich <[email protected]>
Reviewed-by: Nathan Chancellor <[email protected]>
Tested-by: Nathan Chancellor <[email protected]>
Reviewed-by: Masahiro Yamada <[email protected]>
Reviewed-by: Nick Desaulniers <[email protected]>
Signed-off-by: Russell King <[email protected]>
Signed-off-by: Sasha Levin <[email protected]>
acoffeerunner pushed a commit to acoffeerunner/kernel_oneplus_sm8250 that referenced this issue Jun 20, 2021
@tpimh @acoffeerunner
ARM: 8939/1: kbuild: use correct nm executable
eebaeea 
[ Upstream commit 29c623d64f0dcd6aa10e0eabd16233e77114090b ]

Since $(NM) variable can be easily overridden for the whole build, it's
better to use it instead of $(CROSS_COMPILE)nm. The use of $(CROSS_COMPILE)
prefixed variables where their calculated equivalents can be used is
incorrect. This fixes issues with builds where $(NM) is set to llvm-nm.

Link: ClangBuiltLinux/linux#766

Signed-off-by: Dmitry Golovin <[email protected]>
Suggested-by: Nick Desaulniers <[email protected]>
Cc: Matthias Maennich <[email protected]>
Reviewed-by: Nathan Chancellor <[email protected]>
Tested-by: Nathan Chancellor <[email protected]>
Reviewed-by: Masahiro Yamada <[email protected]>
Reviewed-by: Nick Desaulniers <[email protected]>
Signed-off-by: Russell King <[email protected]>
Signed-off-by: Sasha Levin <[email protected]>
khusika pushed a commit to khusika/canting_kernel_xiaomi_sm8150 that referenced this issue Oct 20, 2021
@tpimh
ARM: 8939/1: kbuild: use correct nm executable
0831889 
[ Upstream commit 29c623d64f0dcd6aa10e0eabd16233e77114090b ]

Since $(NM) variable can be easily overridden for the whole build, it's
better to use it instead of $(CROSS_COMPILE)nm. The use of $(CROSS_COMPILE)
prefixed variables where their calculated equivalents can be used is
incorrect. This fixes issues with builds where $(NM) is set to llvm-nm.

Link: ClangBuiltLinux/linux#766

Signed-off-by: Dmitry Golovin <[email protected]>
Suggested-by: Nick Desaulniers <[email protected]>
Cc: Matthias Maennich <[email protected]>
Reviewed-by: Nathan Chancellor <[email protected]>
Tested-by: Nathan Chancellor <[email protected]>
Reviewed-by: Masahiro Yamada <[email protected]>
Reviewed-by: Nick Desaulniers <[email protected]>
Signed-off-by: Russell King <[email protected]>
Signed-off-by: Sasha Levin <[email protected]>
Signed-off-by: Khusika Dhamar Gusti <[email protected]>
DozNaka pushed a commit to DozNaka/KawaKernel-A217X that referenced this issue Apr 5, 2022
@tpimh @DozNaka
ARM: 8939/1: kbuild: use correct nm executable
98b27b3 
[ Upstream commit 29c623d64f0dcd6aa10e0eabd16233e77114090b ]

Since $(NM) variable can be easily overridden for the whole build, it's
better to use it instead of $(CROSS_COMPILE)nm. The use of $(CROSS_COMPILE)
prefixed variables where their calculated equivalents can be used is
incorrect. This fixes issues with builds where $(NM) is set to llvm-nm.

Link: ClangBuiltLinux/linux#766

Signed-off-by: Dmitry Golovin <[email protected]>
Suggested-by: Nick Desaulniers <[email protected]>
Cc: Matthias Maennich <[email protected]>
Reviewed-by: Nathan Chancellor <[email protected]>
Tested-by: Nathan Chancellor <[email protected]>
Reviewed-by: Masahiro Yamada <[email protected]>
Reviewed-by: Nick Desaulniers <[email protected]>
Signed-off-by: Russell King <[email protected]>
Signed-off-by: Sasha Levin <[email protected]>
DozNaka pushed a commit to DozNaka/a217f-s7 that referenced this issue Apr 5, 2022
@tpimh @DozNaka
ARM: 8939/1: kbuild: use correct nm executable
2187c33 
[ Upstream commit 29c623d64f0dcd6aa10e0eabd16233e77114090b ]

Since $(NM) variable can be easily overridden for the whole build, it's
better to use it instead of $(CROSS_COMPILE)nm. The use of $(CROSS_COMPILE)
prefixed variables where their calculated equivalents can be used is
incorrect. This fixes issues with builds where $(NM) is set to llvm-nm.

Link: ClangBuiltLinux/linux#766

Signed-off-by: Dmitry Golovin <[email protected]>
Suggested-by: Nick Desaulniers <[email protected]>
Cc: Matthias Maennich <[email protected]>
Reviewed-by: Nathan Chancellor <[email protected]>
Tested-by: Nathan Chancellor <[email protected]>
Reviewed-by: Masahiro Yamada <[email protected]>
Reviewed-by: Nick Desaulniers <[email protected]>
Signed-off-by: Russell King <[email protected]>
Signed-off-by: Sasha Levin <[email protected]>
bggRGjQaUbCoE pushed a commit to bggRGjQaUbCoE/android_kernel_samsung_sm8250-mohammad92 that referenced this issue Apr 5, 2023
@tpimh @bggRGjQaUbCoE
ARM: 8939/1: kbuild: use correct nm executable
b27c107 
[ Upstream commit 29c623d64f0dcd6aa10e0eabd16233e77114090b ]

Since $(NM) variable can be easily overridden for the whole build, it's
better to use it instead of $(CROSS_COMPILE)nm. The use of $(CROSS_COMPILE)
prefixed variables where their calculated equivalents can be used is
incorrect. This fixes issues with builds where $(NM) is set to llvm-nm.

Link: ClangBuiltLinux/linux#766

Signed-off-by: Dmitry Golovin <[email protected]>
Suggested-by: Nick Desaulniers <[email protected]>
Cc: Matthias Maennich <[email protected]>
Reviewed-by: Nathan Chancellor <[email protected]>
Tested-by: Nathan Chancellor <[email protected]>
Reviewed-by: Masahiro Yamada <[email protected]>
Reviewed-by: Nick Desaulniers <[email protected]>
Signed-off-by: Russell King <[email protected]>
Signed-off-by: Sasha Levin <[email protected]>
Bakoubak pushed a commit to Bakoubak/old-android_kernel_lenovo_amar that referenced this issue Jan 23, 2024
@tpimh @Bakoubak
ARM: 8939/1: kbuild: use correct nm executable
14f6194 
[ Upstream commit 29c623d64f0dcd6aa10e0eabd16233e77114090b ]

Since $(NM) variable can be easily overridden for the whole build, it's
better to use it instead of $(CROSS_COMPILE)nm. The use of $(CROSS_COMPILE)
prefixed variables where their calculated equivalents can be used is
incorrect. This fixes issues with builds where $(NM) is set to llvm-nm.

Link: ClangBuiltLinux/linux#766

Signed-off-by: Dmitry Golovin <[email protected]>
Suggested-by: Nick Desaulniers <[email protected]>
Cc: Matthias Maennich <[email protected]>
Reviewed-by: Nathan Chancellor <[email protected]>
Tested-by: Nathan Chancellor <[email protected]>
Reviewed-by: Masahiro Yamada <[email protected]>
Reviewed-by: Nick Desaulniers <[email protected]>
Signed-off-by: Russell King <[email protected]>
Signed-off-by: Sasha Levin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tpimh tpimh

Labels
[ARCH] arm32 This bug impacts ARCH=arm [BUG] linux A bug that should be fixed in the mainline kernel. [FIXED][LINUX] 5.5 This bug was fixed in Linux 5.5 [TOOL] llvm-nm The issue is relevant to LLVM nm
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tpimh @nickdesaulniers @nathanchance