Release: v0.38.0 #3152
Release: v0.38.0 #3152
Conversation
|
I've been manually testing using this release: https://github.com/elliottwilliams/aws-sdk-ios/releases/tag/2.23.2 |
…--use-xcframeworks ...and vice versa.
cbc3d8f
to
f7e8fcf
Compare
|
I was investigating this feature recently, so I decided to verify it with a different setup! Setup
Steps followed
{
"1.0": "https://github.com/zendesk/chat_providers_sdk_ios/archive/refs/tags/2.10.0.zip"
}
Result
Thanks to all who contributed, looking forward to the release! |
Checking for ".xcframework" first allows for an asset like
MyFramework.framework.xcframework.zip
to be preferred over
MyFramework.zip
Case-insensitive comparison allows for names like
`MyFramework.XCFramework.zip` to be accepted.
These events are emitted before we know whether we've downloaded an xcframework or framework binary, so better to be ambiguous about it than try to guess the extension ahead of time. Before: *** Downloading aws-sdk-ios.framework binary at "2.23.2" After: *** Downloading aws-sdk-ios binary at "2.23.2"
…rameworks This allows a dependency to release _some_ assets as xcframeworks and others as frameworks. Carthage will download both, and will prefer xcframeworks when --use-xcframeworks is given.
|
Is there an ETA when this awesome work will land to master? |
|
@elliottwilliams @tmspzz is there an ETA for this release branch to be merged? |
|
soon™ :) Everything I know of that we need is merged, I just need to shore up release notes with the other maintainers. |
|
@elliottwilliams Can I ask if the current contents of |
|
@elliottwilliams This is great, and we'd love to use it and update it on Edit: Firebase dropped support for Carthage while it's awaiting this PR. |
Is any updates on ETA? |
|
This work would make my April sunnier :) |
|
@ikesyo @jspahrsummers @mdiep @jdhealy Are there any update from your side guys? Really looking forward to this version 👍 🚀 |
This preserves behavior in binary projects, which until now have not had any naming convention. GitHub release assets are now filtered to enforce their long-standing naming convention _before_ being passed to binaryAssetPrioritization.
|
Hi again – I've got bandwidth again to move forward with this, hence new commits! I appreciate your patience. The problem we need to solve before this is release-worthy is we need binary framework authors to have a way to publish xcframeworks without breaking backwards compatibility with older versions of Carthage. 082faaf allows binary projects to publish multiple download URLs for a release, by joining them together into one URL using an {
"1.0.0": "https://example.com/Foo.framework.zip?alt=https://example.com/Foo.xcframework.zip"
}Since HTTP servers tend to ignore query parameters by default, Carthage <= 0.37.0 can download |
Bumps version to 0.38.0
Small behavior change that came up while working on release notes for #3123: Currently, Carthage will only download prebuilt assets whose names contain
.framework. Now, it'll also download assets whose names.xcframework. If a release has both framework and xcframework assets, it'll choose which set to download based the --use-xcframeworks flag.