Support new pycue configuration paths. #972
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've tested this on Mac and Windows now, ready for review. |
|
Last call for review here before I merge. Changes have been discussed by the TSC so I don't think there's anything controversial here. |
This was referenced Dec 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link the Issue(s) this Pull Request is related to.
#785
Summarize your change.
The user-visible change here is there are a few new ways to define the config used by the
opencuelibrary (and anything that depends on it e.g. CueGUI):OPENCUE_CONFIG_FILEcan be used to point to the YAML config file.~/.config/opencue/opencue.yamlis used as a default path for the YAML config (this uses%APPDATA%on Windows).OPENCUE_CONFare still supported.To achieve this there are a few minor changes:
opencue.cuebotto make sure we're not breaking anything.opencue.configmodule, and haveopencue.cuebotutilize this.opencue.configto support the new environment variable and default path.opencue.configto test the new code.