Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add create show dialog (#892) #930

Conversation

IdrisMiles
Copy link
Contributor

Link the Issue(s) this Pull Request is related to.

Fixes #892

Summarize your change.

  • Implement a dialog for creating shows and setting up their
    subscriptions.
  • Add right click action to the show widget for creating new shows.

create_show

@IdrisMiles
Copy link
Contributor Author

I ended up making the add show feature a menu action as I thought it was a bit more consistent with the rest of cuegui, but if we feel like it isn't obvious enough happy to make it an actual button as I mocked out in the ticket

- Implement a dialog for creating shows and setting up their
  subscriptions.
 - Add right click action to show widget for creating new shows.
@bcipriano
Copy link
Collaborator

Hm, yeah I am thinking that putting that option in a context menu that appears when you click on an existing show is counter-intuitive. Also what happens if you have a fresh OpenCue install with no existing shows yet? Maybe a button would be better here.

@IdrisMiles
Copy link
Contributor Author

IdrisMiles commented Feb 25, 2021

That's a good point, justed tested and the context menu only shows if right clicking on a show, if the table is empty it doesn't show.
Will make it a button

EDIT: Actually you can have the menu show with just the "create show" option on an empty table, just need to re-jig the context menu method slightly. But a button is still more obvious

@IdrisMiles
Copy link
Contributor Author

create_show_button

Copy link
Collaborator

@bcipriano bcipriano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks!

@larsbijl larsbijl merged commit 070e23a into AcademySoftwareFoundation:master Apr 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add CueGUI functionality for adding new projects
3 participants