[PyOutline] Add spec_version #919
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
larsbijl
approved these changes
Feb 14, 2021
bcipriano
requested changes
Feb 15, 2021
| @@ -34,6 +34,8 @@ | |||
|
|
|||
| import six | |||
|
|
|||
| from packaging.version import Version | |||
There was a problem hiding this comment.
nit: This import can be moved above the import six line (grouping third-party imports together alphabetically)
pyoutline/tests/specver_test.py
Outdated
| # limitations under the License. | ||
|
|
||
| """ | ||
| Tests for the outline.depend module. |
There was a problem hiding this comment.
This docstring should be updated I think.
0a2ac30
to
8401b10
Compare
|
addressed comments. |
bcipriano
approved these changes
Feb 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #918
It allows deploying clients (PyOutline) before updating Cuebot, with specifying spec_version in outline.cfg.