Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dockerignore so that the sandbox env can be run mutliple times. #879

Merged

Conversation

larsbijl
Copy link
Contributor

Exclude a few other directories as well that are not needed during
docker builds.

Closes #878

Copy link
Collaborator

@bcipriano bcipriano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

One minor comment.

.dockerignore Outdated Show resolved Hide resolved
Exclude a few other directories as well that are not needed during
docker builds.

Closes AcademySoftwareFoundation#878
@bcipriano
Copy link
Collaborator

Looking at the failing Github checks, we're seeing an error from the get-changed-files Action we're using.

Error: The head commit for this pull_request event is not ahead of the base commit. Please submit an issue on this action's GitHub repo.

Despite the error, the action appears to be working as intended -- it produces the list of changed files which then pass the check. But the error is causing the pipeline to show as failed.

This appears to be an issue with force-pushes as mentioned in jitterbit/get-changed-files#4 and jitterbit/get-changed-files#11.

Checks LGTM, so I'll force-merge this and see if we can resolve the pipeline issue separately.

@bcipriano bcipriano merged commit bf128e4 into AcademySoftwareFoundation:master Jan 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docker-compose sandbox can't be run twice
2 participants