Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce RQD_TAGS for setting tags to RQD host #875

Merged
merged 2 commits into from
Jan 22, 2021

Conversation

splhack
Copy link
Contributor

@splhack splhack commented Dec 16, 2020

RQD container build script usually knows which tags should be assigned to the RQD container.
This PR allows the build script can generate rqd.conf file with RQD_TAGS to set the tags to the RQD.

Copy link
Contributor

@larsbijl larsbijl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@bcipriano bcipriano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great idea, and thank you so much for adding the test as well!

@bcipriano bcipriano merged commit 7341f82 into AcademySoftwareFoundation:master Jan 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants