Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Host.os to pycue wrapper #852

Merged
merged 1 commit into from
Dec 15, 2020

Conversation

splhack
Copy link
Contributor

@splhack splhack commented Dec 8, 2020

To read os value from RQD hosts.

Copy link
Collaborator

@bcipriano bcipriano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one minor question about the docstring.

@@ -403,6 +403,12 @@ def lockState(self):
"""
return self.data.lock_state

def os(self):
"""
:rtype: opencue.os
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the rtype here is just str, right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

eh, yes, updated. thanks!

@bcipriano bcipriano merged commit 2228f16 into AcademySoftwareFoundation:master Dec 15, 2020
@splhack splhack deleted the pycue_os branch December 16, 2020 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants