Introduce RQD_BECOME_JOB_USER to allow to not use root privilege #847
Conversation
|
|
There was a problem hiding this comment.
This is a great change and overall looks good to me. Thank you for sending it!
The only thing I'm thinking about here is the naming of the new config value. In practice, the reason RQD needs to run as root is because, when kicking off a render, it then switches (via su) to the user who launched the job. From the user's perspective, the behavior they would be toggling is that user switching -- running as root is only the means to that end.
So maybe the new constant should be named something like RQD_BECOME_JOB_USER or something like that? Open to other ideas. I feel like this would make the purpose of the setting more clear, what do you think?
|
Yes I will change the constant to the suggested name. The ultimate goal of the change for us is, just to avoid things rquired root privilege (because it is not allowed on our system.) |
|
Updated to use |
This PR allows RQD to run without root privilege.