Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add IPv6 support #845

Merged
merged 5 commits into from
Jan 23, 2021
Merged

Add IPv6 support #845

merged 5 commits into from
Jan 23, 2021

Conversation

splhack
Copy link
Contributor

@splhack splhack commented Dec 1, 2020

This PR is addressing IPv6-only hosting for RQD machines.

Issue

  • The machine doesn't have any valid IPv4 address.
    • Cuebot can't reach the IPv4 address which is given by RQD via gethostbyname.

Solution

  • Use getaddrinfo when RQD_USE_IPV6_AS_HOSTNAME config variable is True.
  • Increase the length of hostnames from 30 to 45 in the database schema.
    • The length 45 is defined by POSIX, INET6_ADDRSTRLEN (which is 46 == 45 + NULL.)

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Dec 1, 2020 •
edited

CLA Signed

The committers are authorized under a signed CLA.

@splhack
Copy link
Contributor Author

splhack commented Dec 1, 2020 •
edited

Hi, I have a question about Corporate CLA.
What is the preferred way to sign it? The document looks like there are several ways to do it?

https://github.com/AcademySoftwareFoundation/OpenCue/blob/master/tsc/ccla.md

please complete and sign this Agreement using the electronic signature portal made available to you by the Project or its third-party service providers, or email a PDF of the signed agreement to [email protected].

--
EDITED: figured out and processed CCLA.
https://docs.linuxfoundation.org/lfx/v/v2/communitybridge/easycla/contributors/corporate-contributor

This was referenced Dec 1, 2020
Merged
Merged
@splhack
Copy link
Contributor Author

splhack commented Dec 15, 2020

Added unit tests.

bcipriano
bcipriano approved these changes Jan 15, 2021
View reviewed changes
Copy link
Collaborator

@bcipriano bcipriano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change LGTM! Thank you!

bcipriano
bcipriano requested changes Jan 15, 2021
View reviewed changes
Copy link
Collaborator

@bcipriano bcipriano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah actually I forgot one small thing -- this PR changes the database schema so we need to do a minor version bump -- update VERSION.in at the root level of the repository to 0.4 -> 0.5.

@bcipriano bcipriano mentioned this pull request Jan 15, 2021
Merged
@splhack
Copy link
Contributor Author

splhack commented Jan 16, 2021

@bcipriano sure, done 🙂

@larsbijl larsbijl merged commit 92a8670 into AcademySoftwareFoundation:master Jan 23, 2021
@splhack splhack mentioned this pull request Jan 24, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bcipriano bcipriano bcipriano requested changes

@DiegoTavares DiegoTavares Awaiting requested review from DiegoTavares DiegoTavares is a code owner

@gregdenton gregdenton Awaiting requested review from gregdenton

@jrray jrray Awaiting requested review from jrray

@larsbijl larsbijl Awaiting requested review from larsbijl

@smith1511 smith1511 Awaiting requested review from smith1511

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@splhack @bcipriano @larsbijl