Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redirect DTD http request to the resource file #850

Merged
merged 3 commits into from
Feb 4, 2021
Merged

Redirect DTD http request to the resource file #850

merged 3 commits into from
Feb 4, 2021

Conversation

splhack
Copy link
Contributor

@splhack splhack commented Dec 1, 2020

Cuebot requires to bind TCP 8080 port for providing http access to Job XML DTD (http://localhost:8080/spcue/dtd/cjsl-1.9.dtd.) But it isn't necessary because the http request can be redirected to Jar resource file via EntityResolver. This allows to disable http server.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Dec 1, 2020 •
edited

CLA Signed

The committers are authorized under a signed CLA.

@larsbijl
Copy link
Contributor

larsbijl commented Dec 1, 2020

Hey @splhack, Thank you for this contribution! would you be able to sign the CLA please?

@splhack
Copy link
Contributor Author

splhack commented Dec 1, 2020

@larsbijl Yes, I'm just looking for the most convenient way to sign Corporate CLA.
#845 (comment)

@splhack
Copy link
Contributor Author

splhack commented Dec 1, 2020

@larsbijl figured out and processed CCLA✍️

@splhack splhack mentioned this pull request Jan 31, 2021
Open
@splhack
Copy link
Contributor Author

splhack commented Jan 31, 2021

Added unittests.

This PR is kinda important since Cuebot no longer needs to launch web server.
Thus Cuebot won't cause TCP 8080 port conflict with other process or other container,
and it won't need to reach localhost:8080 at all.

@larsbijl larsbijl self-assigned this Feb 3, 2021
@larsbijl
Copy link
Contributor

larsbijl commented Feb 3, 2021

shall we remove the port 8080 export from the sandbox/docker-compose.yaml?

@splhack
Copy link
Contributor Author

splhack commented Feb 3, 2021

shall we remove the port 8080 export from the sandbox/docker-compose.yaml?

Oh, yes. Apparently that the only one is referring TCP 8080.
(I believe we can ignore cuebot/oracle/xe/run_db_container.sh since Oracle support is now deprecating)

https://github.com/AcademySoftwareFoundation/OpenCue/search?q=8080

@larsbijl larsbijl merged commit a2a3642 into AcademySoftwareFoundation:master Feb 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@larsbijl larsbijl larsbijl approved these changes

@bcipriano bcipriano Awaiting requested review from bcipriano bcipriano is a code owner

@DiegoTavares DiegoTavares Awaiting requested review from DiegoTavares DiegoTavares is a code owner

@gregdenton gregdenton Awaiting requested review from gregdenton

@jrray jrray Awaiting requested review from jrray

@smith1511 smith1511 Awaiting requested review from smith1511

@IdrisMiles IdrisMiles Awaiting requested review from IdrisMiles

Assignees

@larsbijl larsbijl

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@splhack @larsbijl