Add progress status for layers #829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add progressbar calculated based on layer completion status. Closes AcademySoftwareFoundation#769
|
|
bcipriano
reviewed
Feb 2, 2021
| if frame.data.state == opencue.api.job_pb2.SUCCEEDED: | ||
| progress = 100 | ||
| elif frame.data.state == opencue.api.job_pb2.RUNNING: | ||
| progress = int(cuegui.Progress.progress(frame.id())) |
There was a problem hiding this comment.
@larsbijl Question about this change -- cuegui.Progress on this line, what does that refer to? Is there meant to be a new class/module added in this change that is missing?
There was a problem hiding this comment.
This is a change we have in our branch where we use progress information gathered from the frame out of redis.
it must have slipped in.
This section on progress for the TYPE_FRAME can be removed as we don't have this implemented yet.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add progress bar calculated based on layer completion status.
Closes #769