Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Remove simplejson dependency #823

Merged
merged 1 commit into from
Nov 3, 2020
Merged

refactor: Remove simplejson dependency #823

merged 1 commit into from
Nov 3, 2020

Conversation

IdrisMiles
Copy link
Contributor

Link the Issue(s) this Pull Request is related to.
Fixes #789

Summarize your change.

Remove simplejson as a dependency and rely on the standard json library shipped with python. One less dependency to worry about.

bcipriano
bcipriano approved these changes Nov 2, 2020
View reviewed changes
Copy link
Collaborator

@bcipriano bcipriano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Glad it was that easy :)

@bcipriano bcipriano merged commit e18084e into AcademySoftwareFoundation:master Nov 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@larsbijl larsbijl larsbijl approved these changes

@bcipriano bcipriano bcipriano approved these changes

@DiegoTavares DiegoTavares Awaiting requested review from DiegoTavares DiegoTavares is a code owner

@gregdenton gregdenton Awaiting requested review from gregdenton

@jrray jrray Awaiting requested review from jrray

@smith1511 smith1511 Awaiting requested review from smith1511

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Drop simplejson dependency in favor of standard json library
3 participants
@IdrisMiles @larsbijl @bcipriano