Make job archive cutoff a config setting. #777
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@DiegoTavares @gregdenton @larsbijl @smith1511 Hi all, could I get a review on this please? |
|
Should we remove the |
|
@larsbijl I think so, yeah -- looking at the code it doesn't seem to be used. In general I'm actually in favor of moving in the other direction -- moving config into the database so it can be easily adjusted on the fly, though I see that as a larger change needing some more discussion first. |
larsbijl
approved these changes
Oct 1, 2020
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link the Issue(s) this Pull Request is related to.
Fixes #776
Summarize your change.
This value has previously been hardcoded -- this moves it to
opencue.propertiesso it can be configured via that file or via the--history.archive_jobs_cutoff_hours=NCLI flag.