Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add timeout and LLU timeout #761

Merged

Conversation

larsbijl
Copy link
Contributor

Add support for layers to have timeout.

If a frame goes past it's hard timeout it get's killed.

LLU timeout is usually a lower value that check when the last log
update has happend. if no update happens in the LLU window it's also
killed.

Closes #462

Copy link
Collaborator

@bcipriano bcipriano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good! I think we'll just need to clean up the comments around versioning to make it clear that upgrading here will cause some incompatibility and needs some extra care.

cuebot/src/main/resources/public/dtd/cjsl-1.9.dtd Outdated Show resolved Hide resolved
@larsbijl larsbijl force-pushed the 462-layer-timeout branch 2 times, most recently from 0b961a7 to b039b02 Compare November 15, 2020 15:27
Copy link
Collaborator

@bcipriano bcipriano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change LGTM. Just need to resolve the conflicts here and we'll be ready to merge.

Add support for layers to have timeout.

If a frame goes past it's hard timeout it get's killed.

LLU timeout is usually a lower value that check when the last log
update has happend. if no update happens in the LLU window it's also
killed.

Closes AcademySoftwareFoundation#462
@larsbijl
Copy link
Contributor Author

Done

@larsbijl
Copy link
Contributor Author

@bcipriano this should be ready to merge

Copy link
Collaborator

@bcipriano bcipriano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@larsbijl larsbijl merged commit dff882c into AcademySoftwareFoundation:master Jan 23, 2021
@splhack splhack mentioned this pull request Jan 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Optional timeout for layers
2 participants