fixed sed hack with 2to3 #709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcipriano
approved these changes
Jun 8, 2020
requirements.txt
Outdated
| @@ -11,3 +11,4 @@ pyfakefs==3.6 | |||
| PyYAML==5.1 | |||
| simplejson==3.16.0 | |||
| six==1.11.0 | |||
| 2to3==1.0 | |||
There was a problem hiding this comment.
Let's keep this list alphabetized, so 2to3 should be the first line in the file.
|
@bcipriano i think the only check remaining is CLA authorization, is that something i need to do too, otherwise i have pushed all the other changes |
|
Yep, this looks good!
It is -- if you follow the "Please click here to be authorized" link in that comment it should walk you through the process of signing the CLA. |
|
@bcipriano its all done you can merge it now |
|
Perfect, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in PR #669
a fresh build that replaces sed hack with 2to3 everywhere, fixes #660
Replaced sed imports with the usage of 2to3 tool everywhere, the changes were mostly in the dockerfiles but there were 1-2 shell scripts too
Added 2to3 in the requrements too