fix filter alignment in monitor host panel #675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcipriano
reviewed
Mar 31, 2020
cuegui/cuegui/HostMonitor.py
Outdated
| @@ -122,6 +122,7 @@ def __filterAllocationSetup(self, layout): | |||
|
|
|||
| btn = QtWidgets.QPushButton("Filter Allocation") | |||
| btn.setMaximumHeight(FILTER_HEIGHT) | |||
| btn.setStyleSheet(" width: 120px;"); | |||
There was a problem hiding this comment.
It would be great if we could find a way for this to be adaptive to the text contained within the button, so for example if the button's text grows the button will grow with it.
For example, could we set button's padding instead of setting an explicit size?
If so, can we set this in the stylesheet (darkpalette.qss) so it fixes this for ALL buttons, instead of just these two?
There was a problem hiding this comment.
Ya, that definetly sounds better.
Will do that.
There was a problem hiding this comment.
@bcipriano Updated the PR. Please review.
bcipriano
approved these changes
Apr 6, 2020
gregdenton
approved these changes
Apr 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #672 by properly aligning the dropdown arrows with the text in Allocation and HardwareState filter in monitor hosts panel in CueGUI.