Version number pulled from version.in file to constant.py #662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
issue AcademySoftwareFoundation#641 Using os module pulled the version number from VERSION.in file. Default value is set to 'UNKNOWN'.
|
|
|
@srbhss Hi, I appreciate the work but please don't work on issues or send PRs for issues that you are not assigned to. This is laid out in our Contributing guide: https://www.opencue.io/contributing/opencue/contributing/#github-issues |
|
@bcipriano Sir please assign me to this issue , I would like to work on this issue. |
bcipriano
requested changes
Mar 24, 2020
|
@bcipriano please give it a look. |
bcipriano
requested changes
Mar 25, 2020
|
@bcipriano Sir I have added "1.3.0" as the default version if file doesn't exist as suggested. |
|
@gregdenton @larsbijl Please review this PR. |
|
@smith1511 would this logic of |
|
I've just tested it out on Windows and it works as expected |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #641
Automatically pull the version number from VERSION.in file.
Default value is set to 'UNKNOWN'.