Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix moving hosts between allocs in cueadmin. #654

Merged
merged 2 commits into from
Apr 27, 2020
Merged

Fix moving hosts between allocs in cueadmin. #654

merged 2 commits into from
Apr 27, 2020

Conversation

bcipriano
Copy link
Collaborator

Link the Issue(s) this Pull Request is related to.
Fixes #653

Summarize your change.
Pretty straightforward. setAllocation wants the wrapper object, not the underlying protobuf data.

gregdenton
gregdenton approved these changes Mar 18, 2020
View reviewed changes
Copy link
Collaborator

@gregdenton gregdenton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

to09
to09 reviewed Mar 22, 2020
View reviewed changes
Copy link
Contributor

@to09 to09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It generates no error now, i.e TypeError: 'str' object is not callable

@bcipriano bcipriano mentioned this pull request Mar 25, 2020
Closed
@bcipriano
Copy link
Collaborator Author

@larsbijl @smith1511 Need a second review here please.

@bcipriano
Copy link
Collaborator Author

This is an uncontroversial change so I'm going to force-merge.

@bcipriano bcipriano merged commit ad2c754 into AcademySoftwareFoundation:master Apr 27, 2020
@bcipriano bcipriano deleted the fix-move-alloc branch April 27, 2020 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@to09 to09 to09 left review comments

@gregdenton gregdenton gregdenton approved these changes

@jrray jrray Awaiting requested review from jrray

@larsbijl larsbijl Awaiting requested review from larsbijl

@smith1511 smith1511 Awaiting requested review from smith1511

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cueadmin fails to move a host between allocations
3 participants
@bcipriano @gregdenton @to09