Fixing blank submission dropdown for LineEdit in CueSubmit #650
Conversation
…er-white issue in the dropdown
|
|
|
I'm not sure why the 3 tests are failing. From the logs, it looks like it's not able to connect to the cuebot? Are my changes breaking or is it something else? |
|
Ah, yeah I'm guessing you are running into the bug that should be fixed by #648. It's most likely not your code that broke it. I'll try to move my PR along and get it merged quickly so we can verify that. |
|
@shiva-kannan Ok #648 is merged so you should be good to go. Please rebase/merge |
|
Done. Let me know if it looks okay |
There was a problem hiding this comment.
Change LGTM, approved!
I'm not sure why the tests didn't re-run automatically -- yours isn't the only PR this has happened for, so it seems there's some problem with the Github/Azure integration. Anyway I triggered the build manually and you can see tests completed successfully:
https://dev.azure.com/cipriano0988/OpenCue%20Testing/_build/results?buildId=760&view=results
So I think we're good here. We'll just wait for a second approval from one of the other project committers, and we'll be good to merge this.
|
Great, thank you! |
|
@larsbijl @smith1511 @gregdenton Need a second review here. Thank you! |
Associated Issue: #275
Change summary:
QCompleter on the LineEdit for CueSubmit widgets was rendering white text over a white background and hence seemed like blank suggestions.
Added a background specifically for the popup listview in the style.py and used it to set the style of the completer pop up list view.
Why this change?
This maintains the look of the widget and helps solve the blank suggestion bug