Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Batch of fixes for filters, matchers, and actions. #624

Merged
merged 5 commits into from
Feb 24, 2020
Merged

Batch of fixes for filters, matchers, and actions. #624

merged 5 commits into from
Feb 24, 2020

Conversation

bcipriano
Copy link
Collaborator

Link the Issue(s) this Pull Request is related to.
Fixes #623

Summarize your change.

  • Fix backend code for modifying actions -- the servant was trying to operate on objects without IDs populated, which caused it to fail silently.
  • Fix various uses of enum values in the filters dialog.
  • Fix filter ordering (actually a fix for ordering in lots of widgets -- problem was in a base class).
  • Don't reorder filters until changes have been processed, to make sure we're sorting on the latest data.

@bcipriano bcipriano mentioned this pull request Feb 8, 2020
Closed
larsbijl
larsbijl approved these changes Feb 8, 2020
View reviewed changes
Copy link
Contributor

@larsbijl larsbijl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bcipriano
Copy link
Collaborator Author

@smith1511 @gregdenton Need a second review here.

@dinesy may be interested as well as I think SPI uses this feature heavily.

@bcipriano
Copy link
Collaborator Author

Hi @gregdenton could you take a look at this one?

gregdenton
gregdenton approved these changes Feb 22, 2020
View reviewed changes
Copy link
Collaborator

@gregdenton gregdenton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@bcipriano bcipriano merged commit f347994 into AcademySoftwareFoundation:master Feb 24, 2020
@bcipriano bcipriano deleted the filter-fixes branch February 24, 2020 21:01
@bcipriano bcipriano mentioned this pull request Feb 27, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@larsbijl larsbijl larsbijl approved these changes

@gregdenton gregdenton gregdenton approved these changes

@jrray jrray Awaiting requested review from jrray

@smith1511 smith1511 Awaiting requested review from smith1511

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Filters/matchers/actions are broken
3 participants
@bcipriano @larsbijl @gregdenton