Prepend every rqd log line with a timestamp #1286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not all applications launched on rqd have logs with a timestamp, which makes is difficult to debug jobs that are taking more than expected on the cue. This feature prepends a timestamp for every line.
|
There are some pipeline failures on things that were not touched by this PR |
bcipriano
approved these changes
May 24, 2023
| @@ -567,6 +567,7 @@ def setUp(self): | |||
|
|
|||
| @mock.patch('platform.system', new=mock.Mock(return_value='Linux')) | |||
| @mock.patch('tempfile.gettempdir') | |||
| @mock.patch('rqd.rqcore.pipe_to_file', new=mock.MagicMock()) | |||
There was a problem hiding this comment.
If we have to mock this, it means we're testing the pipe_to_file codepath instead of the default one, right?
Can we set RQD_PREPEND_TIMESTAMP = False in this test so we're testing the default codepath instead?
48abfd8
into
AcademySoftwareFoundation:master
12 of 14 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link the Issue(s) this Pull Request is related to.
Some tools don't have timestamp intergrated into their logging format, which makes it hard to identify what steps on a process might be slower than normal. The simpler solution is to change the logging format on these tools, but that's not always possible.
Summarize your change.
To overcome the challange mentioned above, a new feature was made available to automatically prepend a timestamp to every rqlog line. This feature can be turned on/off using the constant RQD_PREPEND_TIMESTAMP.