Add a new property max_show_stale_days to control show expiration rule #1208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The recently introduced PR#1151 ended up changing the default behaviour of the system, where shows would only be marked as inactive manually. This PR keeps the functionally but adds a new property entry to set the number of days a show needs to be stale (No new jobs) to be marked as inactive and sets the default to -1, which deactivates the feature.
bcipriano
requested changes
Sep 29, 2022
cuebot/src/main/java/com/imageworks/spcue/dao/postgres/ShowDaoJdbc.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Diego Tavares da Silva <[email protected]>
bcipriano
approved these changes
Sep 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link the Issue(s) this Pull Request is related to.
Fixes #1205 caused by #1151
Summarize your change.
The recently introduced PR #1151 ended up changing the default behaviour of the system, where shows would only be marked as inactive manually. This PR keeps the functionally but adds a new property entry to set the number of days a show needs to be stale (No new jobs) to be marked as inactive and sets the default to -1, which deactivates the feature.