Replace qApp with a new cuegui.App library. #1193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@DiegoTavares This is ready for review but could use some more testing. As you can see from the last few commits in this branch I found a few spots where the whole |
|
Working on building a package with pyside6 internally to test this. |
|
Awesome, thanks. FWIW PySide6 shouldn't be required to test this, I believe. It could be tested separately. And maybe it should be, to isolate any issues and help unbreak our CI pipelines. |
DiegoTavares
approved these changes
Oct 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link the Issue(s) this Pull Request is related to.
Fixes #1192.
Summarize your change.
We introduce a new
Applibrary which is used to create and access the application instance. This replaces our use ofQtGui.qAppfor the same purpose.This allows us to avoid the
no attribute 'qApp'error that's been a regular occurrence for a long time and has recently start causing consistent CI pipeline failures. See #1192 for more details.Many classes now store the instance as
self.appwhich looks a bit cleaner and in several modules allows us to avoid importing the wholeQtGuimodule just to access the application instance.With the new library, lint is now able to trace
CueGuiApplicationreferences back to the actual class, so we're able to remove a ton ofdisable=no-memberrules that were everywhere in that code. Also a fewdisable=attribute-defined-outside-initrules. There are still somedisable=no-memberrules left due to lint's inability to follow PySide signals, but that will have to be handled separately.