Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cuebot: Handle exceptions when moving hosts with running cores #1172

Merged
merged 2 commits into from
Oct 25, 2022
Merged

cuebot: Handle exceptions when moving hosts with running cores #1172

merged 2 commits into from
Oct 25, 2022

Conversation

akim-ruslanov
Copy link
Contributor

Link the Issue(s) this Pull Request is related to.
When you attempt to change allocation of a hoist with running cores, cuebot will throw an error that is not handled properly on cuegui side. This will render the application unusable until you relaunch it.

Summarize your change.
When we make a cuebot call, there is a second layer for exception that will take every possible exception. Just like with CueException, an error message will appear with explanaition and the user can continue using the application after pressing OK. This will make sure it takes into account any unexpected error thrown by cuebot.

bcipriano
bcipriano reviewed Jul 12, 2022
View reviewed changes
Copy link
Collaborator

@bcipriano bcipriano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you have an example of the error you're trying to catch here? I'm wondering, if the error is on the cuebot side, why it's not coming back as CueException.

@akim-ruslanov
Copy link
Contributor Author

Do you have an example of the error you're trying to catch here? I'm wondering, if the error is on the cuebot side, why it's not coming back as CueException.

@bcipriano an example could be com.imageworks.spcue.EntityModificationError. This error is thrown when you try to change allocation of a host with running cores. To replicate:

  1. Launch opencue
  2. Go to the "Manage Hosts" plugin
  3. Filter the hosts to "a" allocation
  4. Select a host that is running frames (the "Idle" is less than the "Cores")
  5. Right click the host and select "Change Allocation"
  6. Select any other allocation and click "Ok"
  7. Check the shell for the error
  8. The gui freezes and needs to be restarted to continue

@akim-ruslanov akim-ruslanov force-pushed the github-handle-exceptions-when-moving-hosts-with-running-cores branch from de68795 to 812a702 Compare August 10, 2022 19:39
@akim-ruslanov
Copy link
Contributor Author

Found an actual reason for the problem. setAllocation API call was not encapsulated with @util.grpcExceptionParser decorator. This means that error were not parsed correctly so they could not get caught correctly either.

@akim-ruslanov akim-ruslanov force-pushed the github-handle-exceptions-when-moving-hosts-with-running-cores branch from 9a9ad87 to 7673e7c Compare August 10, 2022 20:18
@bcipriano bcipriano merged commit 234a9ce into AcademySoftwareFoundation:master Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bcipriano bcipriano bcipriano approved these changes

@gregdenton gregdenton Awaiting requested review from gregdenton

@jrray jrray Awaiting requested review from jrray

@smith1511 smith1511 Awaiting requested review from smith1511

@larsbijl larsbijl Awaiting requested review from larsbijl

@DiegoTavares DiegoTavares Awaiting requested review from DiegoTavares DiegoTavares is a code owner

@IdrisMiles IdrisMiles Awaiting requested review from IdrisMiles

@splhack splhack Awaiting requested review from splhack

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@akim-ruslanov @bcipriano