cuebot: Make frames and layers readonly after job is done #1164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4249cf3
to
323007f
Compare
|
This issue has been discussed on the TSC: To avoid impacting other pipelines where it would make sense to retry frames on finished jobs, this feature should be configurable by a flag on the config file. |
620266c
to
05f6333
Compare
1a797c2
to
d956bdb
Compare
I added a flag to toggle this feature. The default behavior will be allowing the frames/layers be editable even if the flag is not defined. I am hoping that this would make sure it won't break any pipelines. To toggle this feature on, you will have to explicitly add flags for both layer and frame in the prop file. |
d956bdb
to
e6e64c5
Compare
e6e64c5
to
d729ce3
Compare
bcipriano
reviewed
Jul 12, 2022
cuebot/src/main/java/com/imageworks/spcue/servant/ManageJob.java
Outdated
Show resolved
Hide resolved
cuebot/src/main/java/com/imageworks/spcue/servant/ManageJob.java
Outdated
Show resolved
Hide resolved
cuebot/src/main/java/com/imageworks/spcue/servant/ManageJob.java
Outdated
Show resolved
Hide resolved
DiegoTavares
reviewed
Aug 8, 2022
cuebot/src/main/java/com/imageworks/spcue/servant/ManageJob.java
Outdated
Show resolved
Hide resolved
DiegoTavares
approved these changes
Aug 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link the Issue(s) this Pull Request is related to.
Retrying a frame in a finished job will cause the frame to go back into the waiting state and the job will return to the cue. This even bypasses checks on duplicate job names, so two jobs with the same name can be running at the same time. Hence, it should be disallowed to retry frames on finished jobs, and the finished jobs should be read only.
Summarize your change.
Endpoints that edit layers or frames now check whether or not the job is finished. If it is finished, then an error is returned. This will make sure the job is readonly from cuebot side.