Add OOM Increase field to Service Properties #1160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
338c6d7
to
0247af1
Compare
|
Depends on #1157 |
|
Can we get a screenshot of what it looks like with the new field? |
Sure! The newly added field is highlighted in the screenshot with the red border.
|
Allow setting minimum memory increase for services through Cuecommander HD Ticket: http://rails.spimageworks.com/helpdesk/tickets/446586
Previously, the min. value for the input was 512. This caused confusion when db value for min_memory_increase was 0. Also includes check to prevent users from setting the field to 0.
0247af1
to
81fd354
Compare
DiegoTavares
approved these changes
Jul 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow setting minimum memory increase in Cuecommander Service Properties menu