Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: gRPC GetHost method #1148

Merged
merged 1 commit into from
May 11, 2022
Merged

Fix: gRPC GetHost method #1148

merged 1 commit into from
May 11, 2022

Conversation

prOOrc
Copy link
Contributor

@prOOrc prOOrc commented May 10, 2022

Duplicate of #1117

@prOOrc prOOrc mentioned this pull request May 10, 2022
Closed
bcipriano
bcipriano approved these changes May 10, 2022
View reviewed changes
Copy link
Collaborator

@bcipriano bcipriano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change LGTM and I see unit tests are passing. I think those failing checks can be resolved with a merge/rebase from master.

@bcipriano bcipriano merged commit 101cdbf into AcademySoftwareFoundation:master May 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bcipriano bcipriano bcipriano approved these changes

@gregdenton gregdenton Awaiting requested review from gregdenton

@jrray jrray Awaiting requested review from jrray

@smith1511 smith1511 Awaiting requested review from smith1511

@larsbijl larsbijl Awaiting requested review from larsbijl

@DiegoTavares DiegoTavares Awaiting requested review from DiegoTavares DiegoTavares is a code owner

@IdrisMiles IdrisMiles Awaiting requested review from IdrisMiles

@splhack splhack Awaiting requested review from splhack

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@prOOrc @bcipriano