Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cuegui] fix job monitor filter behavior #1139

Merged

Conversation

aoblet
Copy link
Contributor

@aoblet aoblet commented May 1, 2022

Link the Issue(s) this Pull Request is related to.

Summarize your change.

  • Fix previous regressions
  • Improve cuegui monitor filter job
    • Allow regex usage in any case
    • Clear all jobs before new job, this is what to expect when doing a new search
    • Save LoadFinished setting in cuetopia preference file

@DiegoTavares
Copy link
Collaborator

One of the errors (#1122) was being caused by a part of a new feature that bleed into master accidentally on (#1115).

I've just merged the conflicting change into this branch, @aoblet can you check if it's still working on your end?

@aoblet
Copy link
Contributor Author

aoblet commented May 3, 2022

Group dependent
@DiegoTavares it works like a charm.
Note: I would suggest to add a tooltip on groupDependent. It might be a bit difficult to understand at first glance.

Job right click
There is a bug still while right clicking on a job.
Introduced by the last commit on group dependent.

self.__menuActions.jobs().addAction(menu, "showProgBar")

  File "/tmp/OpenCue/cuegui/cuegui/JobMonitorTree.py", line 383, in contextMenuEvent
    self.__menuActions.jobs().addAction(menu, "showProgBar")
  File "/tmp/OpenCue/cuegui/cuegui/MenuActions.py", line 139, in addAction
    info = getattr(self, "%s_info" % actionName)
AttributeError: 'JobActions' object has no attribute 'showProgBar_info'

@aoblet aoblet changed the title [cuegui] Job Monitor fix filter behavior [cuegui] fix job monitor filter behavior May 3, 2022
@aoblet
Copy link
Contributor Author

aoblet commented May 17, 2022

@DiegoTavares what should we do ?

@DiegoTavares
Copy link
Collaborator

Sorry for the delay on this topic. I'm investigating what else might have bled into this feature

@DiegoTavares
Copy link
Collaborator

A fix for the reported error has been pushed on #1154

@bcipriano
Copy link
Collaborator

#1154 is merged now.

@DiegoTavares DiegoTavares merged commit 3f974d2 into AcademySoftwareFoundation:master Jul 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants