Update CueJobMonitorTree only with new data #1128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed processUpdate to only update in mem dict self._items when "new" jobs are retrieved during the API call. Calling API every 22 seconds with large number of jobs bogs down the gui. Fixed _getUpdate to include the root group and its' associated jobs, this fn returned a different count then the in mem ds. Fixed the recursive fn __getNestedIds, had previously returned only groups and not the associated jobs, so when processUpdate compared the len() of what is in self._items vs what was last retrieved ie current == set(rpcObjects[1]) line 417, it was never the same and continuously tried rebuilding self._items for each interval.
0269143
to
2325ffc
Compare
…om:roregan/OpenCue into bug-fix-building-nestedgroups
DiegoTavares
approved these changes
Apr 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summarize your change.
Fixed processUpdate to only update in mem dict
self._itemswhen "new" jobs are retrieved during the API call. Calling API every 22 seconds with large number of jobs bogs down the gui. Fixed_getUpdateto include the root group and its'associated jobs, this fn returned a different count then the in mem ds. Fixed the recursive fn
__getNestedIds, had previously returned only groups and not the associated jobs, so when processUpdate compared thelen()of what is in self._items vs what was last retrieved iecurrent == set(rpcObjects[1]) line 417, it was never the same and continuously tried rebuilding self._items for each interval.