Post jobs should inherit parent environment variables #1107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Environment variables set to parent jobs can be useful for post job frames.
bcipriano
approved these changes
Mar 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Environment variables set to parent jobs can be useful for post job frames.
Link the Issue(s) this Pull Request is related to.
We have a scenario where post jobs require having access to the same environments from the parent. As post_jobs are use to run postProcess jobs, it's invisible to pyoutline module developers that those layers will be passed to a different job (post_job), so they expect to have the same environment as the job they are binding postProcess layers to.
Summarize your change.
The change simple copies all environment variables set at the spec level to the postJob object.