Fix NIMBY lock and refactor Nimby to Factory #1106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nimby now has two modes, Select and Pynput. Windows hosts will activate the Pynput mode by default. Bug fix: Two changes in rqcore.py: start() under isDesktop to call onNimbyLock() if nimby override is true. Second in launchFrame, added another condition if Nimby override is True and user is active to not launch frame. Revamped logging, removed print statements.
cf6f429
to
cd51942
Compare
cd51942
to
ab0d587
Compare
DiegoTavares
approved these changes
Mar 28, 2022
bcipriano
approved these changes
Mar 28, 2022
rqd/rqd/rqnimby.py
Outdated
| try: | ||
| import pynput | ||
| except ImportError: | ||
| pass |
There was a problem hiding this comment.
Do we really want to eat this error? IIUC it should be required if rqd.rqconstants.USE_NIMBY_PYNPUT == True, maybe add a check for that? Let's at least log something if it fails.
There was a problem hiding this comment.
Sure thing, I can add a log for the import error.
f7480ae
to
fc911a4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summarize your change.
Refactor Nimby to a Factory, now has two modes, Select and Pynput. Windows hosts will activate the Pynput mode by default. Fixed Nimby lock override, revamped logging removed print statements.
Nimby lock was reverting irregardless if the user was using the desktop, turning Nimby into a Factory for Windows capability.