Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Log4j to 2.16. #1080

Merged
merged 9 commits into from
Dec 12, 2022

Conversation

bcipriano
Copy link
Collaborator

Link the Issue(s) this Pull Request is related to.
Fixes #1079

Summarize your change.
This includes an upgrade from the 1.x -> 2.x line.

@bcipriano
Copy link
Collaborator Author

@DiegoTavares @roulaoregan-spi Would love to get your thoughts and some additional testing on this.

Config has changed a lot from 1.x -> 2.x. I've tested it locally and everything seems to be in line with what was logged previously but it would be great to get confirmation.

@DiegoTavares
Copy link
Collaborator

It's not like we're pressed to fix this right away, as our version is not on the list of affected versions for the infamous zero day, but I agree it's about time to upgrade it.

The changes look good to me. We're integrating it into our dev environment soon testing during Jan before releasing it to production on the end of Jan.

@splhack
Copy link
Contributor

splhack commented Dec 20, 2021

looks like need to upgrade to 2.17
https://logging.apache.org/log4j/2.x/index.html

@DiegoTavares
Copy link
Collaborator

@bcipriano this PR needs some love

@bcipriano bcipriano requested a review from splhack as a code owner July 13, 2022 02:27
@bcipriano
Copy link
Collaborator Author

@DiegoTavares Thanks for the reminder. I've brought it up to date with master. Only issue with that merge is the HEALTH log that was added recently. I've added that into the new log4j2.properties file.

Please take another look, if it's looking good let's get it merged.

@grimjak
Copy link

grimjak commented Dec 6, 2022

Hey, what's the status on this. We're looking to get cleaner logs out of opencue and it would be great to have this merged.

Thanks

Graham

@bcipriano
Copy link
Collaborator Author

@grimjak Thanks for the reminder! Yes, this has been sitting too long and we should get it merged finally.

I've brought the change up to date with master, just going to do a final check with some of the others to make sure we're good to merge.

@grimjak
Copy link

grimjak commented Dec 6, 2022

Thanks for the prompt response. I've applied your changes to our test deployment which is mostly up to date with master. I don't see anything in health.log although that could easily be something I missed. Otherwise the changes all seem to work fine

@bcipriano
Copy link
Collaborator Author

@grimjak Thanks for trying it out! Indeed, for health.log I had an appender but no logger set up. That's been corrected now.

@bcipriano
Copy link
Collaborator Author

TSC confirmed we are good to merge this now.

@bcipriano bcipriano merged commit 91f2244 into AcademySoftwareFoundation:master Dec 12, 2022
@bcipriano bcipriano deleted the upgrade-log4j branch December 12, 2022 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade log4j
4 participants