Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RQD] Replace isAlive with is_alive #1052

Merged
merged 2 commits into from
Oct 22, 2021
Merged

[RQD] Replace isAlive with is_alive #1052

merged 2 commits into from
Oct 22, 2021

Conversation

splhack
Copy link
Contributor

@splhack splhack commented Oct 15, 2021

@splhack splhack force-pushed the fix-1038 branch 3 times, most recently from e1619c5 to 8820bae Compare October 15, 2021 15:44
@splhack
Copy link
Contributor Author

splhack commented Oct 19, 2021

waiting #1048 merge to rebase.

@splhack
Copy link
Contributor Author

splhack commented Oct 20, 2021

rebased onto master (#1048 was merged)

@bcipriano bcipriano merged commit fc0b509 into AcademySoftwareFoundation:master Oct 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bcipriano bcipriano bcipriano approved these changes

@DiegoTavares DiegoTavares Awaiting requested review from DiegoTavares DiegoTavares is a code owner

@gregdenton gregdenton Awaiting requested review from gregdenton

@IdrisMiles IdrisMiles Awaiting requested review from IdrisMiles

@jrray jrray Awaiting requested review from jrray

@larsbijl larsbijl Awaiting requested review from larsbijl

@smith1511 smith1511 Awaiting requested review from smith1511

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Python 3.9 is not compatible, isAlive attribute has been deprecated.
2 participants
@splhack @bcipriano