Get RSS and %CPU for Windows #1023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcipriano
reviewed
Sep 12, 2021
rqd/rqd/rqmachine.py
Outdated
| pids = [frame.pid for frame in list( | ||
| filter(lambda frame: frame.pid > 0, values) | ||
| )] | ||
| # pylint: disable=E1101 |
There was a problem hiding this comment.
Let's use the name of the rule being disabled instead of the ID -- IMO it makes it more easily understood and is consistent with the rest of the code. I think this one is no-member, right?
There was a problem hiding this comment.
updated to disable=no-member
| elif platform.system() == "Windows": | ||
| winpsIsAvailable = False | ||
| try: | ||
| import winps |
There was a problem hiding this comment.
Do users need to perform any steps to install winps? Or it's just loaded directly from the source directory?
There was a problem hiding this comment.
Yes, users who are using source code need to install it using setup.py if they want to use the module on Windows.
cd rqd/winps
python setup.py install
If OpenCue supports PyPI, it can be installed automatically with RQD dependencies.
bcipriano
approved these changes
Dec 4, 2021
DiegoTavares
approved these changes
Dec 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
winps) to traverse process tree of each frame to get RSS (WorkingSetSize) and %CPU (the same way as Linux with /proc). The code path will be disabled if the native module is not available.__updateGpuAndLlu) from Linux and Windows