Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug in Monitor Job Details due to setShortcut arg type. #1007

Merged
merged 1 commit into from
Aug 2, 2021
Merged

Fix bug in Monitor Job Details due to setShortcut arg type. #1007

merged 1 commit into from
Aug 2, 2021

Conversation

bcipriano
Copy link
Collaborator

@bcipriano bcipriano commented Aug 2, 2021 •
edited

Link the Issue(s) this Pull Request is related to.
Fixes #1005

Summarize your change.
In a Python 3 environment, this works fine as-is. However in Python 2 you get the error

TypeError: 'PySide2.QtWidgets.QAction.setShortcut' called with wrong argument types:
  PySide2.QtWidgets.QAction.setShortcut(long)
Supported signatures:
  PySide2.QtWidgets.QAction.setShortcut(PySide2.QtGui.QKeySequence)

Adding the explicit use of QKeySequence gets this working again in both Python 2 and 3.

@bcipriano bcipriano changed the title Make setShortcut arg an explicit QKeySequence. Fix bug in Monitor Job Details due to setShortcut arg type. Aug 2, 2021
@bcipriano bcipriano merged commit 606d7d4 into AcademySoftwareFoundation:master Aug 2, 2021
@bcipriano bcipriano deleted the explicit-qkeysequence branch August 2, 2021 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DiegoTavares DiegoTavares Awaiting requested review from DiegoTavares DiegoTavares is a code owner

@gregdenton gregdenton Awaiting requested review from gregdenton

@IdrisMiles IdrisMiles Awaiting requested review from IdrisMiles

@jrray jrray Awaiting requested review from jrray

@larsbijl larsbijl Awaiting requested review from larsbijl

@smith1511 smith1511 Awaiting requested review from smith1511

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Failed to load plugin module: Monitor Job Details
1 participant
@bcipriano