Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combine frame update #1006

Merged

Conversation

splhack
Copy link
Contributor

@splhack splhack commented Aug 1, 2021

The current code uses two separate for-loops to update the same frames in HostReportHandler.
It looks like it's not significant, but it doubled the database transactions for no particular reasons, specially with multiple running frames.

  • Find frame
  • Update memory usage
  • Find frame (redundant)
  • Update LLU time (can be combined with the memory usage UPDATE)

This PR will combine those to reduce HostReport handling latency and database load which are big deals with a massive render farm.

  • Find frame
  • Update memory usage and LLU time

Also this PR will establish a way to test Host Report with running job.

Copy link
Collaborator

@bcipriano bcipriano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice change, LGTM!

@bcipriano bcipriano merged commit da28ae9 into AcademySoftwareFoundation:master Sep 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants