Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade gRPC and PySide Python dependencies. #1003

Merged
merged 3 commits into from
Jul 31, 2021
Merged

Upgrade gRPC and PySide Python dependencies. #1003

merged 3 commits into from
Jul 31, 2021

Conversation

bcipriano
Copy link
Collaborator

@bcipriano bcipriano commented Jul 31, 2021 •
edited

Link the Issue(s) this Pull Request is related to.
Fixes #755, #784

Summarize your change.
Upgrading both dependencies to a new version as both are quite old at this point and not supported in newer Python versions.

  • New PySide gets rid of the qApp shortcut, so I add a line into CueGUI and CueSubmit to create it. This avoids needing massive code changes in both GUI apps.
  • Newest gRPC that supports Python 2 does not publish wheels anymore for newer Python versions, so we need to split that dependency to use different versions on Python 2 and 3.
  • In the new PySide signals are recognized as functions, which causes lint issues. Most of the changed lines in this PR are due to disable lint checks on signals, as lint isn't able to detect the signal members such as connect.

@bcipriano bcipriano marked this pull request as ready for review July 31, 2021 22:39
@bcipriano
Copy link
Collaborator Author

Unfortunately, the older dependency versions we're currently using are now completely broken for me -- can't create a new virtualenv on my mac workstation. So this is now blocking a new release, and I need to merge it ASAP.

I've tested this out on mac/windows/linux and don't see any issues.

@bcipriano bcipriano merged commit 409c2a7 into AcademySoftwareFoundation:master Jul 31, 2021
@bcipriano bcipriano deleted the upgrade-grpc-pyside branch July 31, 2021 22:58
@bcipriano bcipriano mentioned this pull request Jul 31, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DiegoTavares DiegoTavares Awaiting requested review from DiegoTavares DiegoTavares is a code owner

@gregdenton gregdenton Awaiting requested review from gregdenton

@IdrisMiles IdrisMiles Awaiting requested review from IdrisMiles

@jrray jrray Awaiting requested review from jrray

@larsbijl larsbijl Awaiting requested review from larsbijl

@smith1511 smith1511 Awaiting requested review from smith1511

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upgrade PySide to a more recent version.
1 participant
@bcipriano