First round of unit tests for FilterDialog. (#661)

AcademySoftwareFoundation · Apr 13, 2020 · 2480183 · 2480183
1 parent 9ba86c8
commit 2480183
Show file tree

Hide file tree

Showing 3 changed files with 432 additions and 4 deletions.
diff --git a/cuegui/cuegui/FilterDialog.py b/cuegui/cuegui/FilterDialog.py
@@ -55,6 +55,16 @@
 
 class FilterDialog(QtWidgets.QDialog):
  def __init__(self, show, parent=None):
+ """
+ Creates an instance of the FilterDialog.
+
+ Filters are segmented by show, so a show must be provided.
+
+ :type show: opencue.wrappers.show.Show
+ :param show: the show to manage filters for
+ :type parent: PySide2.QtWidgets.QWidget.QWidget
+ :param parent: the parent widget
+ """
  QtWidgets.QDialog.__init__(self, parent)
  self.__show = show
 
@@ -112,8 +122,8 @@ def __init__(self, show, parent=None):
 
  def __createFilter(self):
  """Prompts the user to create a new filter"""
- (value, choice) = QtWidgets.QInputDialog.getText(self, "Add filter", "Filter name?",
-   QtWidgets.QLineEdit.Normal, "")
+ (value, choice) = QtWidgets.QInputDialog.getText(
+ self, "Add filter", "Filter name?", QtWidgets.QLineEdit.Normal, "")
  if choice:
  self.__filters.addObject(self.__show.createFilter(str(value)))
 
@@ -258,8 +268,8 @@ def createMatcher(self):
  return
 
  self.addObject(self.__filter.createMatcher(
- getattr(opencue.api.filter_pb2, str(matchSubject)),
- getattr(opencue.api.filter_pb2, str(matchType)),
+ opencue.compiled_proto.filter_pb2.MatchSubject.Value(str(matchSubject)),
+ opencue.compiled_proto.filter_pb2.MatchType.Value(str(matchType)),
  str(input)))
 
  def deleteAllMatchers(self):