android: add linker flag to support flexible page sizes in Android 15 #872
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ccrowell-kr
commented
Nov 26, 2024
| @@ -116,6 +121,10 @@ publishing { | |||
| } | |||
|
|
|||
| signing { | |||
| setRequired { | |||
There was a problem hiding this comment.
Happy to remove this or change the implementation. I added it because it allows us to run ./gradlew publishToMavenLocal and use the mavenLocal() repository rather than manually including the aar for testing.
I borrowed the implementation from this discussion on the gradle forums
| @@ -1,2 +0,0 @@ | |||
| <?xml version="1.0" encoding="utf-8"?> | |||
There was a problem hiding this comment.
The empty manifest is not required now that namespace is declared in the build.gradle.kts but happy to restore this if desired.
|
Thanks a lot and sorry for the delayed response. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables the Android wrapper to be used in apps running Android 15 on devices with a 16KB page size.
I have tested this locally with a 16KB emulator. Without the flag, the demo app crashes immediately, with the new flag, the demo app works as expected.
Addresses #871